Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 18211008: Add resource ID based download requests in {GDataWapi/Drive} requests. (Closed)

Created:
7 years, 5 months ago by kinaba
Modified:
7 years, 5 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add resource ID based download requests in {GDataWapi/Drive} requests. BUG=254025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209689

Patch Set 1 : Fix test. #

Total comments: 2

Patch Set 2 : Reorder parameters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -40 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/base_requests.h View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/base_requests.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 1 5 chunks +64 lines, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests.h View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 5 chunks +65 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
7 years, 5 months ago (2013-07-02 08:20:48 UTC) #1
hidehiko
lgtm with nitpick. https://codereview.chromium.org/18211008/diff/4001/chrome/browser/google_apis/drive_api_requests.h File chrome/browser/google_apis/drive_api_requests.h (right): https://codereview.chromium.org/18211008/diff/4001/chrome/browser/google_apis/drive_api_requests.h#newcode539 chrome/browser/google_apis/drive_api_requests.h:539: const DownloadActionCallback& download_action_callback, How about move ...
7 years, 5 months ago (2013-07-02 09:17:30 UTC) #2
kinaba
https://codereview.chromium.org/18211008/diff/4001/chrome/browser/google_apis/drive_api_requests.h File chrome/browser/google_apis/drive_api_requests.h (right): https://codereview.chromium.org/18211008/diff/4001/chrome/browser/google_apis/drive_api_requests.h#newcode539 chrome/browser/google_apis/drive_api_requests.h:539: const DownloadActionCallback& download_action_callback, On 2013/07/02 09:17:30, hidehiko wrote: > ...
7 years, 5 months ago (2013-07-02 09:34:59 UTC) #3
hidehiko
lgtm
7 years, 5 months ago (2013-07-02 09:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/18211008/4002
7 years, 5 months ago (2013-07-02 10:08:57 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 12:54:56 UTC) #6
Message was sent while issue was closed.
Change committed as 209689

Powered by Google App Engine
This is Rietveld 408576698