Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 18209022: add missing headers in ppapi/* (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add missing headers in ppapi/* Include a few headers that are required but not already included directly. BUG=259043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211724

Patch Set 1 #

Patch Set 2 : add more missing includes #

Patch Set 3 : more missing includes #

Patch Set 4 : reorder headers to satisfy presubmit check #

Total comments: 4

Patch Set 5 : more reordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ppapi/host/resource_message_filter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/dispatch_reply_message.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/handle_converter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/host_resolver_resource_base.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/talk_resource.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/truetype_font_singleton_resource.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_trace_event_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
@viettrungluu: does this trivial patch look OK to you?
7 years, 5 months ago (2013-07-10 11:19:35 UTC) #1
viettrungluu
https://codereview.chromium.org/18209022/diff/8001/ppapi/proxy/host_resolver_resource_base.cc File ppapi/proxy/host_resolver_resource_base.cc (right): https://codereview.chromium.org/18209022/diff/8001/ppapi/proxy/host_resolver_resource_base.cc#newcode7 ppapi/proxy/host_resolver_resource_base.cc:7: #include "ppapi/proxy/host_resolver_resource_base.h" This include should remain first, on a ...
7 years, 5 months ago (2013-07-12 21:52:12 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/18209022/diff/8001/ppapi/proxy/host_resolver_resource_base.cc File ppapi/proxy/host_resolver_resource_base.cc (right): https://codereview.chromium.org/18209022/diff/8001/ppapi/proxy/host_resolver_resource_base.cc#newcode7 ppapi/proxy/host_resolver_resource_base.cc:7: #include "ppapi/proxy/host_resolver_resource_base.h" On 2013/07/12 21:52:12, viettrungluu wrote: > This ...
7 years, 5 months ago (2013-07-13 06:40:15 UTC) #3
viettrungluu
lgtm
7 years, 5 months ago (2013-07-15 16:39:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18209022/14001
7 years, 5 months ago (2013-07-15 17:27:11 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-15 22:49:58 UTC) #6
Message was sent while issue was closed.
Change committed as 211724

Powered by Google App Engine
This is Rietveld 408576698