Issue 18202005: [Android] Refactor buildbot tests so that they can be used downstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18202005: [Android] Refactor buildbot tests so that they can be used downstream. (Closed)

Created:
7 years, 5 months ago by Siva Chandra

Modified:
7 years, 5 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Refactor buildbot tests so that they can be used downstream. I refactored in the wrong way in r211209 (https://chromiumcodereview.appspot.com/18325030/). This CL fixes that. Note that r211209 is not broken; it is just not usable downstream. BUG=249997 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211454

Patch Set 1 #

Patch Set 2 : Make the error message generic #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	build/android/buildbot/tests/bb_run_bot_test.py	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

sorry, missed this review. LGTM. If presubmit passes, feel free to notry=true. this is only ...

7 years, 5 months ago (2013-07-12 20:56:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/18202005/5001

7 years, 5 months ago (2013-07-12 20:58:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/18202005/5001

7 years, 5 months ago (2013-07-12 21:04:26 UTC) #4

Message was sent while issue was closed.

Change committed as 211454

Expand Messages | Collapse Messages