Reland "components/webdata: Break the dependency on chrome/test/base"

Reland "components/webdata: Break the dependency on chrome/test/base"

This was reverted because it broke android, because I forgot to remove
a line from build/android/pylib/gtest/test_runner.py

BUG=181277
TBR=joi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209348

[tfarina, 2013-06-28 12:52:27]

Relanding...

Marcus, please check my build/android changes. I think I got them right at this
time.

[Jói, 2013-06-28 13:06:38]

LGTM, but please wait for bulach@ to OK it before committing.

Cheers,
Jói

[bulach, 2013-06-28 17:29:20]

lgtm but +frankf, he's more up to date with build/android these days.

one suggestion below:

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:68: 'components/test/data/',
nit: perhaps add /web_database ?

[tfarina, 2013-06-28 17:48:18]

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:68: 'components/test/data/',
On 2013/06/28 17:29:20, bulach wrote:
> nit: perhaps add /web_database ?
I didn't add web_database to antecipate others making usage of that test
directory, i.e if someone come later and add a components/tests/data/foo/, that
will work automatically and it won't need to list yet another entry here.

[bulach, 2013-06-28 17:53:04]

clarification inline:

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:68: 'components/test/data/',
On 2013/06/28 17:48:19, tfarina wrote:
> On 2013/06/28 17:29:20, bulach wrote:
> > nit: perhaps add /web_database ?
> I didn't add web_database to antecipate others making usage of that test
> directory, i.e if someone come later and add a components/tests/data/foo/,
that
> will work automatically and it won't need to list yet another entry here.

the reason for this list is that the android device's "disk" space is fairly
limited, and it's costly to transfer across.. :) I'd rather keep it restrictive
to prevent surprises (in the past, we had new big files checked in, unrelated to
android, that broke our bots.. )
I think frankf and others are working to solve this properly..

[tfarina, 2013-06-29 00:19:30]

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/18201002/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:68: 'components/test/data/',
On 2013/06/28 17:53:04, bulach wrote:
> On 2013/06/28 17:48:19, tfarina wrote:
> > On 2013/06/28 17:29:20, bulach wrote:
> > > nit: perhaps add /web_database ?
> > I didn't add web_database to antecipate others making usage of that test
> > directory, i.e if someone come later and add a components/tests/data/foo/,
> that
> > will work automatically and it won't need to list yet another entry here.
> 
> the reason for this list is that the android device's "disk" space is fairly
> limited, and it's costly to transfer across.. :) I'd rather keep it
restrictive
> to prevent surprises (in the past, we had new big files checked in, unrelated
to
> android, that broke our bots.. )
> I think frankf and others are working to solve this properly..
ok, done.

[commit-bot: I haz the power, 2013-06-29 00:21:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/18201002/9001

[commit-bot: I haz the power, 2013-06-29 21:15:49]

Change committed as 209348