Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 18199004: Fix bug with the avatar menu alignment. (Closed)

Created:
7 years, 5 months ago by Adrian Kuegel
Modified:
7 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Fix bug with the avatar menu alignment. BUG=254364 TEST=In avatar menu of managed user, click on switch user. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209322

Patch Set 1 #

Patch Set 2 : Avoid flicker by calculating new origin in setWindowFrame. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Adrian Kuegel
Hi Robert, can you please review this CL? I fixed it now differently, this avoids ...
7 years, 5 months ago (2013-06-28 13:47:51 UTC) #1
Robert Sesek
lgtm
7 years, 5 months ago (2013-06-28 15:30:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/18199004/3001
7 years, 5 months ago (2013-06-28 17:43:59 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 14:50:41 UTC) #4
Message was sent while issue was closed.
Change committed as 209322

Powered by Google App Engine
This is Rietveld 408576698