cc/resources/ui_resource_client.h - Issue 18191020: UI Resource Manager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/resources/ui_resource_client.h

Issue 18191020: UI Resource Manager (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Switched to resource client instead of callback Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_RESOURCES_UI_RESOURCE_CLIENT_H_

	6 #define CC_RESOURCES_UI_RESOURCE_CLIENT_H_

	7

	8 #include "base/callback.h"

	9 #include "base/memory/ref_counted.h"

	10

	11 namespace cc {

	12

	13 class UIResourceBitmap;

	14

	15 typedef int UIResourceId;

	16

	17 class UIResourceClient {

	18 public:

	19 virtual scoped_refptr<UIResourceBitmap> Create(bool resource_lost) = 0;
	aelias_OOO_until_Jul13 2013/07/26 23:35:32 Could you pass in the UIResourceID as argument her Could you pass in the UIResourceID as argument here? It could be useful to some clients. I suggest renaming this to "GetBitmap" and add a comment: "GetBitmap() will be called once soon after resource creation and then will be called afterwards whenever the GL context is lost, on the same thread that LayerTreeHost::CreateUIResource was called on. It is only safe to delete a UIResourceClient object after DeleteUIResource has been called for all IDs associated with it. A valid bitmap always must be returned but it doesn't need to be the same size or format as the original." powei 2013/07/30 21:47:00 Done. Show quoted text On 2013/07/26 23:35:32, aelias wrote: > Could you pass in the UIResourceID as argument here? It could be useful to some > clients. > > I suggest renaming this to "GetBitmap" and add a comment: "GetBitmap() will be > called once soon after resource creation and then will be called afterwards > whenever the GL context is lost, on the same thread that > LayerTreeHost::CreateUIResource was called on. It is only safe to delete a > UIResourceClient object after DeleteUIResource has been called for all IDs > associated with it. A valid bitmap always must be returned but it doesn't need > to be the same size or format as the original." Done.
	20 virtual ~UIResourceClient() {}

	21 };

	22

	23 } // namespace cc

	24

	25 #endif // CC_RESOURCES_UI_RESOURCE_CLIENT_H_

OLD	NEW

« cc/resources/scoped_ui_resource.h ('K') | « cc/resources/ui_resource_bitmap.cc ('k') | cc/test/fake_scoped_ui_resource.h » ('j') | cc/trees/layer_tree_host.h » ('J')