UI Resource Manager

cc/layers/scrollbar_layer.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_SCROLLBAR_LAYER_H_
 #define CC_LAYERS_SCROLLBAR_LAYER_H_
 
 #include "cc/base/cc_export.h"
 #include "cc/input/scrollbar.h"
 #include "cc/layers/contents_scaling_layer.h"
 #include "cc/layers/scrollbar_theme_painter.h"
 #include "cc/resources/layer_updater.h"
 
 namespace cc {
-class CachingBitmapContentLayerUpdater;
-class ResourceUpdateQueue;
 class ScrollbarThemeComposite;
+class UIResourceBitmap;
+
+typedef int UIResourceId;
 
 class CC_EXPORT ScrollbarLayer : public ContentsScalingLayer {
  public:
   virtual scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl)
       OVERRIDE;
 
   static scoped_refptr<ScrollbarLayer> Create(
       scoped_ptr<Scrollbar> scrollbar,
       int scroll_layer_id);
 
   int scroll_layer_id() const { return scroll_layer_id_; }
   void SetScrollLayerId(int id);
 
   virtual bool OpacityCanAnimateOnImplThread() const OVERRIDE;
 
   ScrollbarOrientation Orientation() const;
 
   // Layer interface
-  virtual void SetTexturePriorities(const PriorityCalculator& priority_calc)
-      OVERRIDE;
   virtual bool Update(ResourceUpdateQueue* queue,
                       const OcclusionTracker* occlusion) OVERRIDE;
   virtual void SetLayerTreeHost(LayerTreeHost* host) OVERRIDE;
   virtual void PushPropertiesTo(LayerImpl* layer) OVERRIDE;
   virtual void CalculateContentsScale(float ideal_contents_scale,
                                       float device_scale_factor,
                                       float page_scale_factor,
                                       bool animating_transform_to_screen,
                                       float* contents_scale_x,
                                       float* contents_scale_y,
                                       gfx::Size* content_bounds) OVERRIDE;
 
   virtual ScrollbarLayer* ToScrollbarLayer() OVERRIDE;
 
  protected:
   ScrollbarLayer(scoped_ptr<Scrollbar> scrollbar,
                  int scroll_layer_id);
   virtual ~ScrollbarLayer();
 
  private:
-  bool UpdatePart(CachingBitmapContentLayerUpdater* painter,
-                  LayerUpdater::Resource* resource,
-                  gfx::Rect rect,
-                  ResourceUpdateQueue* queue);
-  void CreateUpdaterIfNeeded();
   gfx::Rect ScrollbarLayerRectToContentRect(gfx::Rect layer_rect) const;
   gfx::Rect OriginThumbRect() const;
 
-  bool is_dirty() const { return !dirty_rect_.IsEmpty(); }
-
   int MaxTextureSize();
   float ClampScaleToMaxTextureSize(float scale);
 
+  void RasterizeTrackAndThumb();
+
+  // Callback functions for UI Resource Manager
+  scoped_refptr<UIResourceBitmap> GetTrackBitmap(bool resource_lost);
+  scoped_refptr<UIResourceBitmap> GetThumbBitmap(bool resource_lost);
+
   scoped_ptr<Scrollbar> scrollbar_;
 
   int thumb_thickness_;
   int thumb_length_;
   gfx::Rect track_rect_;
+  gfx::Rect thumb_rect_;
   int scroll_layer_id_;
 
-  unsigned texture_format_;
-
-  gfx::RectF dirty_rect_;
-
-  scoped_refptr<CachingBitmapContentLayerUpdater> track_updater_;
-  scoped_refptr<CachingBitmapContentLayerUpdater> thumb_updater_;
-
-  // All the parts of the scrollbar except the thumb
-  scoped_ptr<LayerUpdater::Resource> track_;
-  scoped_ptr<LayerUpdater::Resource> thumb_;
+  UIResourceId track_ui_resource_id_;

[aelias_OOO_until_Jul13, 2013/07/24 02:57:46]

I think we should contain these in a separate helper class that looks like:

class ScopedUIResource {
 public:
  ScopedUIResource() {}
  ScopedUIResource(LayerTreeHost* host, scoped_refptr<UIResourceBitmap> bitmap)
{ reset(host, bitmap); }
  ~ScopedUIResource() { clear(); }

  void clear();
  UIResourceID reset(LayerTreeHost* host, scoped_refptr<UIResourceBitmap>
bitmap);

  UIResourceID id() const { return id_; }
 private:
  UIResourceId id_;
  scoped_refptr<UIResourceBitmap> bitmap_;
  LayerTreeHost* host_;
};

This will be a common pattern for UIResource users and avoid leaks.

[powei, 2013/07/25 20:48:45]

Done.

+  UIResourceId thumb_ui_resource_id_;
+  scoped_refptr<UIResourceBitmap> track_bitmap_;
+  scoped_refptr<UIResourceBitmap> thumb_bitmap_;
 
   DISALLOW_COPY_AND_ASSIGN(ScrollbarLayer);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_SCROLLBAR_LAYER_H_