Use js-test-{pre,post}.js for ime-composition-events LayoutTest

Use js-test-{pre,post}.js for ime-composition-events LayoutTest.

BUG=none
TEST=LayoutTest (run_webkit_tests.sh fast/events/ime-composition-events-001.html)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153330

[kochi, 2013-06-28 08:17:57]

Hi tkent-san,

This is a subsequent CL of
https://codereview.chromium.org/18041002/

If the previous one is done, could you review this?
Thanks,

[tkent, 2013-07-01 05:41:30]

lgtm

> Use js-test-{pre,post}.js 

Please add the test name to this line in the description.

Please use consistent quote characters in the test. You use both of ' and ".
FYI: Google style guides recommend to use ' for JavaScript code and " for HTML
markup.

https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
File LayoutTests/fast/events/ime-composition-events-001.html (right):

https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
LayoutTests/fast/events/ime-composition-events-001.html:65:
textInputController.insertText('made');
This line use '

https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
LayoutTests/fast/events/ime-composition-events-001.html:66:
shouldBeEqualToString("test.value", "I made a pen");
This line use "

[kochi, 2013-07-01 06:28:00]

On 2013/07/01 05:41:30, tkent wrote:
> lgtm
> 
> > Use js-test-{pre,post}.js 
> 
> Please add the test name to this line in the description.
> 
> Please use consistent quote characters in the test. You use both of ' and ".
> FYI: Google style guides recommend to use ' for JavaScript code and " for HTML
> markup.
> 
>
https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
> File LayoutTests/fast/events/ime-composition-events-001.html (right):
> 
>
https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
> LayoutTests/fast/events/ime-composition-events-001.html:65:
> textInputController.insertText('made');
> This line use '
> 
>
https://codereview.chromium.org/18185002/diff/1/LayoutTests/fast/events/ime-c...
> LayoutTests/fast/events/ime-composition-events-001.html:66:
> shouldBeEqualToString("test.value", "I made a pen");
> This line use "

Thanks for the review!
Updated the description and fixed the quotation style.

[tkent, 2013-07-01 06:31:39]

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
File LayoutTests/fast/events/ime-composition-events-001.html (right):

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:8: description("This
tests that calling input-method functions sends Composition Events and Text
Events introduced in DOM Level 3. " +
double quote

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:18:
shouldBeEqualToString("event.type", "compositionupdate");
Ditto.

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:23:
shouldBeEqualToString("event.type", "compositionend");
Ditto.

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:28:
shouldBeEqualToString("event.type", "textInput");
Ditto.

[commit-bot: I haz the power, 2013-07-01 06:32:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/18185002/10001

[kochi, 2013-07-01 06:36:41]

Sorry for my hasty fixes and thanks for pointing them out!

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
File LayoutTests/fast/events/ime-composition-events-001.html (right):

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:8: description("This
tests that calling input-method functions sends Composition Events and Text
Events introduced in DOM Level 3. " +
On 2013/07/01 06:31:39, tkent wrote:
> double quote

Done.

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:18:
shouldBeEqualToString("event.type", "compositionupdate");
On 2013/07/01 06:31:39, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:23:
shouldBeEqualToString("event.type", "compositionend");
On 2013/07/01 06:31:39, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/18185002/diff/10001/LayoutTests/fast/events/i...
LayoutTests/fast/events/ime-composition-events-001.html:28:
shouldBeEqualToString("event.type", "textInput");
On 2013/07/01 06:31:39, tkent wrote:
> Ditto.

Done.

[commit-bot: I haz the power, 2013-07-01 07:05:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/18185002/16002

[commit-bot: I haz the power, 2013-07-01 08:40:56]

Change committed as 153330