Replace --no-pager with GIT_PAGER=cat

Replace --no-pager with GIT_PAGER=cat

--no-pager looks ugly in logs and output and makes commands harder to
read. Setting an environment variable is better.

This is a followup to https://chromiumcodereview.appspot.com/14104005/
which added --no-pager.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210503

[Daniel Bratell, 2013-06-28 14:14:24]

Not tested it much but it did allow me to upload this patch.

[M-A Ruel, 2013-07-08 19:10:50]

https://codereview.chromium.org/18173003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode79
git_cl.py:79: env['GIT_PAGER'] = 'cat' # Magic string that prevents a pager.
Move the comment on its own line.

Does this work on Windows?

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode231
git_cl.py:231: env['GIT_PAGER'] = 'cat' # Magical string that disables pagers.
Comment on its own line

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode308
git_cl.py:308: env = os.environ
env = os.environ.copy()

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode309
git_cl.py:309: env['GIT_PAGER'] = 'cat' # Magical string that disables pagers.
Comment on its own line.

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode694
git_cl.py:694: env = os.environ
same

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode1765
git_cl.py:1765: env = os.environ
same

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode1798
git_cl.py:1798: env = os.environ
same

https://codereview.chromium.org/18173003/diff/1/scm.py
File scm.py (right):

https://codereview.chromium.org/18173003/diff/1/scm.py#newcode101
scm.py:101: env = os.environ
same

[iannucci, 2013-07-08 20:21:56]

https://codereview.chromium.org/18173003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode79
git_cl.py:79: env['GIT_PAGER'] = 'cat' # Magic string that prevents a pager.
On 2013/07/08 19:10:50, Marc-Antoine Ruel wrote:
> Move the comment on its own line.
> 
> Does this work on Windows?

(Drive-by: Yeah, GIT_PAGER=cat is a magic value)

[Daniel Bratell, 2013-07-08 22:08:06]

https://codereview.chromium.org/18173003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode79
git_cl.py:79: env['GIT_PAGER'] = 'cat' # Magic string that prevents a pager.
On 2013/07/08 19:10:50, Marc-Antoine Ruel wrote:
> Move the comment on its own line.
> 
> Does this work on Windows?

It seems to work when I test manually and according to the documentation cat is
a magic keyword that disables paging (the unix utility program cat isn't
mentioned).

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode308
git_cl.py:308: env = os.environ
On 2013/07/08 19:10:50, Marc-Antoine Ruel wrote:
> env = os.environ.copy()

I considered it but it's not really necessary since we want this value globally
anyway. I'll add it though.

[M-A Ruel, 2013-07-08 22:15:13]

lgtm

https://codereview.chromium.org/18173003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/18173003/diff/1/git_cl.py#newcode308
git_cl.py:308: env = os.environ
On 2013/07/08 22:08:06, bratell wrote:
> On 2013/07/08 19:10:50, Marc-Antoine Ruel wrote:
> > env = os.environ.copy()
> 
> I considered it but it's not really necessary since we want this value
globally
> anyway. I'll add it though.

First rule of maintainability is to not mutate global states in inner functions.

So either mutate globally at the start of the program or use a copy of the
environment at each call sites. You are doing the later, either is fine with me.

[commit-bot: I haz the power, 2013-07-09 06:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/18173003/6001

[commit-bot: I haz the power, 2013-07-09 06:33:42]

Change committed as 210503