Add pathway to auto-migrate users when Chrome launches

Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
Committed: https://crrev.com/de49c2d22f6c873aac94696ef004ecf8d8dd6b52
Cr-Commit-Position: refs/heads/master@{#383406}

[gone, 2016-03-21 23:33:55]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org, yusufo@chromium.org

[gone, 2016-03-21 23:33:56]

Going to keep on truckin'.  This one depends on the DocumentModeAssassin CL.

[gone, 2016-03-21 23:39:29]

Description was changed from

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
==========

to

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
==========

[Ted C, 2016-03-25 17:38:06]

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/And...
File chrome/android/java/AndroidManifest.xml (right):

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:206: <activity
android:name="org.chromium.chrome.browser.document.UpgradeActivity"
I would use a more verbose name to ensure we don't have name conflicts in the
future.  Something like DocumentToTabbedModeUpgradeActivity or
DocumentToTabbedMigrationActivity

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/res...
File chrome/android/java/res/layout/upgrade_activity.xml (right):

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/upgrade_activity.xml:10:
android:id="@+id/webapp_splash_screen_layout"
something else?

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/upgrade_activity.xml:17:
android:layout_width="@dimen/signin_image_carousel_width"
? that is an odd thing to reference here... any reason we can't just use
wrap_content?

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:234:
finish();
ApiCompatibilityUtils.finishAndRemoveTask(this); ?  I honestly don't know why
we'd use one over the other.

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java
(right):

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:53:
mAlreadyRan = true;
how could we hit the already ran case?  Or is this just a cautious check?

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:63:
continueExecution();
if the activity is destroyed before this is called, will this barf?  Just
wondering if we have to track that to avoid the good ol' android crashes.

https://codereview.chromium.org/1817083003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:100:
}
should we try to launch a main intent otherwise?

[gone, 2016-03-25 22:05:42]

Testing with Activity destruction exposed a StrictMode violation I wasn't
expecting, so that ended up getting changed.  Also tried to make UpgradeActivity
more robust against stopping and things.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
File chrome/android/java/AndroidManifest.xml (right):

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/AndroidManifest.xml:206: <activity
android:name="org.chromium.chrome.browser.document.UpgradeActivity"
On 2016/03/25 17:38:05, Ted C wrote:
> I would use a more verbose name to ensure we don't have name conflicts in the
> future.  Something like DocumentToTabbedModeUpgradeActivity or
> DocumentToTabbedMigrationActivity

Meant for this to be a generic upgrade/migration class.  Move to the browser
package instead.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
File chrome/android/java/res/layout/upgrade_activity.xml (right):

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/res/layout/upgrade_activity.xml:10:
android:id="@+id/webapp_splash_screen_layout"
On 2016/03/25 17:38:05, Ted C wrote:
> something else?

Will be redoing this with the redlines that just came in.  Alright for a follow
up CL?

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/res/layout/upgrade_activity.xml:17:
android:layout_width="@dimen/signin_image_carousel_width"
On 2016/03/25 17:38:05, Ted C wrote:
> ? that is an odd thing to reference here... any reason we can't just use
> wrap_content?

The image was a weird size, IIRC.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:234:
finish();
On 2016/03/25 17:38:05, Ted C wrote:
> ApiCompatibilityUtils.finishAndRemoveTask(this); ?  I honestly don't know why
> we'd use one over the other.

We use finish when something sits on top of this Activity, I think.  I'm not
sure if it makes a difference in this case, but I switched over.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java
(right):

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:53:
mAlreadyRan = true;
On 2016/03/25 17:38:05, Ted C wrote:
> how could we hit the already ran case?  Or is this just a cautious check?

Paranoia.  I'd suggest asserting, but it seems like a bad idea to force a crash
on an upgrade path when we can't even test if asserts are working correctly on
current Android builds.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:63:
continueExecution();
On 2016/03/25 17:38:05, Ted C wrote:
> if the activity is destroyed before this is called, will this barf?  Just
> wondering if we have to track that to avoid the good ol' android crashes.

Reshuffled code around a bit to make it more robust.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/UpgradeActivity.java:100:
}
On 2016/03/25 17:38:05, Ted C wrote:
> should we try to launch a main intent otherwise?

Done.

[Ted C, 2016-03-25 22:15:31]

lgtm

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
File chrome/android/java/res/layout/upgrade_activity.xml (right):

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/res/layout/upgrade_activity.xml:10:
android:id="@+id/webapp_splash_screen_layout"
On 2016/03/25 22:05:41, dfalcantara wrote:
> On 2016/03/25 17:38:05, Ted C wrote:
> > something else?
> 
> Will be redoing this with the redlines that just came in.  Alright for a
follow
> up CL?

That is fine.

https://chromiumcodereview.appspot.com/1817083003/diff/60001/chrome/android/j...
chrome/android/java/res/layout/upgrade_activity.xml:17:
android:layout_width="@dimen/signin_image_carousel_width"
On 2016/03/25 22:05:41, dfalcantara wrote:
> On 2016/03/25 17:38:05, Ted C wrote:
> > ? that is an odd thing to reference here... any reason we can't just use
> > wrap_content?
> 
> The image was a weird size, IIRC.

We should probably give this a more generic name (can be done in the followup)

[Yusuf, 2016-03-25 22:19:55]

lgtm

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java
(right):

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java:97:
private static Intent cacheIntentToFireAfterUpgrade(Intent activityIntent) {
This doesn't really do caching anymore,right?

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java:120: if
(isDestroyed()) return;
isDestroyed() is API > 16, we might have to use APICOmpatibilityUtils or just
cache it ourselves.

[gone, 2016-03-25 22:26:48]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-03-25 22:26:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, yusufo@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1817083003/#ps100001 (title: "Comments")

[commit-bot: I haz the power, 2016-03-25 22:27:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817083003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817083003/100001

[gone, 2016-03-25 22:51:31]

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java
(right):

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java:97:
private static Intent cacheIntentToFireAfterUpgrade(Intent activityIntent) {
On 2016/03/25 22:19:55, Yusuf wrote:
> This doesn't really do caching anymore,right?

Done.

https://chromiumcodereview.appspot.com/1817083003/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/UpgradeActivity.java:120: if
(isDestroyed()) return;
On 2016/03/25 22:19:55, Yusuf wrote:
> isDestroyed() is API > 16, we might have to use APICOmpatibilityUtils or just
> cache it ourselves.

Did what AsyncInitializationActivity did.

[commit-bot: I haz the power, 2016-03-25 23:37:32]

Description was changed from

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
==========

to

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
==========

[commit-bot: I haz the power, 2016-03-25 23:37:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-25 23:40:13]

Description was changed from

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539
==========

to

==========
Add pathway to auto-migrate users when Chrome launches

* For now, a command line flag is required to trigger this pathway:
  --enable-forced-migration

* UpgradeActivity kicks off the DocumentModeAssassin and waits for
  it to finish.  This Activity can only be launched via other
  ChromeActivities, and can be passed an Intent to refire when the
  migration finishes.

  * A MAIN Intent or Intent to start a new DocumentActivity that goes
    through ChromeLauncherActivity will force users through
    UgpradeActivity, instead.  This causes document mode to be flipped
    off, and anything going down the ChromeLauncherActivity pathway
    again should no longer trigger migration.

    This pathway catches new tabs created via VIEW Intents, MAIN
    Intents, CCT Intents, and (sometimes) WebappActivity Intents.

  * AsyncInitializationActivity watches for the need for the migration
    pathway to be triggered when a ChromeActivity subclass starts up.

    This pathway catches Intents that skip ChromeLauncherActivity,
    which includes ChromeTabbedActivity, DocumentActivity, CustomTabActivity,
    and WebappActivity.  These can be launched directly by selecting
    them from Android Recents, or by firing Intents to bring them
    back specifically.

  * The look of this Activity is a stand-in for when we get redlines.
    The animation is also kind of janky, but I'm aiming for functionality
    at this point.

* TabDelegate is no longer allowed to create new DocumentActivities,
  instead deferring down the ChromeLauncherActivity pathway.  This
  catches cases with push notifications triggering a tab to be
  created when they're clicked.

* The preference to enable document mode is hidden once the user
  has migrated.

BUG=582539

Committed: https://crrev.com/de49c2d22f6c873aac94696ef004ecf8d8dd6b52
Cr-Commit-Position: refs/heads/master@{#383406}
==========

[commit-bot: I haz the power, 2016-03-25 23:40:14]

Patchset 6 (id:??) landed as
https://crrev.com/de49c2d22f6c873aac94696ef004ecf8d8dd6b52
Cr-Commit-Position: refs/heads/master@{#383406}