Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/bindings/dart/DartDOMWrapper.h

Issue 18169002: Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Code review fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/dart/inspector/scope-variables-expected.txt ('k') | Source/bindings/dart/DartDebugHooks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartDOMWrapper.h
diff --git a/Source/bindings/dart/DartDOMWrapper.h b/Source/bindings/dart/DartDOMWrapper.h
index a7c6cc080495f19a290c9d088f4ec70b7a0c28a0..2133508bcd6883edafc891052ad61fa97c6d7ba9 100644
--- a/Source/bindings/dart/DartDOMWrapper.h
+++ b/Source/bindings/dart/DartDOMWrapper.h
@@ -188,8 +188,12 @@ private:
{
intptr_t value;
Dart_Handle result = Dart_GetNativeInstanceField(wrapper, index, &value);
- ASSERT(!Dart_IsError(result));
- UNUSED_PARAM(result);
+ // FIXME: the fact that we return 0 on error rather than asserting is
+ // somewhat of a hack. We currently make this method return 0 because
+ // we reuse this method to verify that objects are actually native
+ // Node objects rather than objects that implement the Node interface.
+ if (Dart_IsError(result))
+ return 0;
return reinterpret_cast<void*>(value);
}
« no previous file with comments | « LayoutTests/dart/inspector/scope-variables-expected.txt ('k') | Source/bindings/dart/DartDebugHooks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698