Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: Source/bindings/v8/V8Binding.cpp

Issue 18169002: Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: ready for review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8Binding.cpp
diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp
index 93f7167a1fcdd3619a403b4c7d001d730da3efa0..fff76b945dd1343e25aedae47087a11eb7fc7452 100644
--- a/Source/bindings/v8/V8Binding.cpp
+++ b/Source/bindings/v8/V8Binding.cpp
@@ -311,6 +311,10 @@ DOMWindow* toDOMWindow(v8::Handle<v8::Context> context)
if (!window.IsEmpty())
return V8DOMWindow::toNative(window);
window = global->FindInstanceInPrototypeChain(V8DOMWindow::GetTemplate(context->GetIsolate(), IsolatedWorld));
+ if (window.IsEmpty()) {
vsm 2013/07/15 18:40:29 Is this something to upstream sooner rather than l
Jacob 2013/07/15 22:23:54 The inspector tests will fail without this change
+ // TODO(jacobr): find a better solution.
+ return toDOMWindow(v8::Context::GetEntered());
+ }
ASSERT(!window.IsEmpty());
return V8DOMWindow::toNative(window);
}

Powered by Google App Engine
This is Rietveld 408576698