Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18162003: Only set sysroot for MIPS on linux. (Closed)

Created:
7 years, 5 months ago by benm (inactive)
Modified:
7 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Only set sysroot for MIPS on linux. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209193

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/common.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
benm (inactive)
How does this look?
7 years, 5 months ago (2013-06-27 23:15:05 UTC) #1
Torne
https://codereview.chromium.org/18162003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/18162003/diff/1/build/common.gypi#newcode660 build/common.gypi:660: ['target_arch=="mipsel"', { This should be in the same block; ...
7 years, 5 months ago (2013-06-28 00:09:30 UTC) #2
benm (inactive)
https://codereview.chromium.org/18162003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/18162003/diff/1/build/common.gypi#newcode660 build/common.gypi:660: ['target_arch=="mipsel"', { On 2013/06/28 00:09:30, Torne wrote: > This ...
7 years, 5 months ago (2013-06-28 00:11:59 UTC) #3
Torne
https://codereview.chromium.org/18162003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/18162003/diff/1/build/common.gypi#newcode660 build/common.gypi:660: ['target_arch=="mipsel"', { On 2013/06/28 00:11:59, benm wrote: > On ...
7 years, 5 months ago (2013-06-28 00:17:46 UTC) #4
benm (inactive)
changing os_posix means we skip the mipsel block, i think this is correct?
7 years, 5 months ago (2013-06-28 00:55:00 UTC) #5
Torne
lgtm
7 years, 5 months ago (2013-06-28 01:07:48 UTC) #6
Torne
lgtm lgtm
7 years, 5 months ago (2013-06-28 01:07:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/18162003/8001
7 years, 5 months ago (2013-06-28 01:29:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/18162003/8001
7 years, 5 months ago (2013-06-28 17:50:37 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 18:20:48 UTC) #10
Message was sent while issue was closed. 
Change committed as 209193

Powered by Google App Engine
This is Rietveld 408576698