Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 18161007: Replace angle_path gyp variable with regular path. (Closed)

Created:
7 years, 5 months ago by apatrick_chromium
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d3d11
Visibility:
Public.

Description

Replace angle_path gyp variable with regular path. The switch to angle_dx11 is complete. This is cleanup. I will land this before removing the angle_path variable from build/common.gypi. For media/ TBR=vrk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211908

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/media.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
apatrick_chromium
jamesr: webkit/ piman: the rest thx!
7 years, 5 months ago (2013-07-11 21:32:33 UTC) #1
jamesr
webkit/ lgtm
7 years, 5 months ago (2013-07-11 21:34:38 UTC) #2
piman
lgtm
7 years, 5 months ago (2013-07-11 21:39:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/18161007/5629499534213120
7 years, 5 months ago (2013-07-11 23:03:08 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=14898
7 years, 5 months ago (2013-07-11 23:26:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/18161007/5629499534213120
7 years, 5 months ago (2013-07-16 19:30:03 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 03:00:47 UTC) #7
Message was sent while issue was closed.
Change committed as 211908

Powered by Google App Engine
This is Rietveld 408576698