Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 18145004: IndexedDB: Eliminate WebIDBCursor wrapper (Closed)

Created:
7 years, 5 months ago by jsbell
Modified:
7 years, 5 months ago
Reviewers:
alecflett, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

IndexedDB: Eliminate WebIDBCursor wrapper Cruft from the Blink->Chromium backend move. BUG=234278 TBR=jam@chromium.org R=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209335

Patch Set 1 #

Patch Set 2 : Remove bogus includes #

Patch Set 3 : Add RefIDMap #

Total comments: 1

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -123 lines) Patch
M content/browser/indexed_db/indexed_db_callbacks.h View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks_wrapper.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 2 5 chunks +41 lines, -7 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 3 9 chunks +35 lines, -22 lines 0 comments Download
D content/browser/indexed_db/webidbcursor_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/indexed_db/webidbcursor_impl.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
I'm not sure how I feel about IDMap<scoped_refptr<IndexedDBCursor>, IDMapOwnPointer> - it does the right thing, ...
7 years, 5 months ago (2013-06-27 22:24:28 UTC) #1
jsbell
On 2013/06/27 22:24:28, jsbell wrote: > I'm not sure how I feel about IDMap<scoped_refptr<IndexedDBCursor>, > ...
7 years, 5 months ago (2013-06-27 23:24:24 UTC) #2
jam
lgtm
7 years, 5 months ago (2013-06-28 16:16:29 UTC) #3
alecflett
lgtm as well You could move RefIDMap as well, but the lgtm stands without that
7 years, 5 months ago (2013-06-28 23:59:08 UTC) #4
alecflett
https://chromiumcodereview.appspot.com/18145004/diff/5001/content/browser/indexed_db/indexed_db_dispatcher_host.h File content/browser/indexed_db/indexed_db_dispatcher_host.h (right): https://chromiumcodereview.appspot.com/18145004/diff/5001/content/browser/indexed_db/indexed_db_dispatcher_host.h#newcode95 content/browser/indexed_db/indexed_db_dispatcher_host.h:95: // IDMap for RefCounted types seems like this is ...
7 years, 5 months ago (2013-06-28 23:59:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18145004/12001
7 years, 5 months ago (2013-06-29 00:03:13 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 20:46:00 UTC) #7
Message was sent while issue was closed.
Change committed as 209335

Powered by Google App Engine
This is Rietveld 408576698