[Sync] Trigger unapply + getupdates for persistence errors

[Sync] Trigger unapply + getupdates for persistence errors

Persistence errors are handled by stopping them, reconfiguring with them,
and then as part of the reconfigure process unapplying + doing a sync cycle
for them.

BUG=239828
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210013

[Nicolas Zea, 2013-06-28 00:48:14]

PTAL

[tim (not reviewing), 2013-07-01 21:10:18]

This CL is kind of hard to review without
https://codereview.chromium.org/15701022, might be useful for haitao to take a
peek as well.

https://codereview.chromium.org/18132003/diff/2001/chrome/browser/sync/glue/b...
File chrome/browser/sync/glue/bookmark_model_associator.cc (right):

https://codereview.chromium.org/18132003/diff/2001/chrome/browser/sync/glue/b...
chrome/browser/sync/glue/bookmark_model_associator.cc:715: (native_version !=
sync_version || native_version != 0)) {
So.. this is 

!(native_version == sync_version && native_version == 0)

I think you want to remove this (here and below) :)

https://codereview.chromium.org/18132003/diff/2001/chrome/browser/sync/glue/s...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

https://codereview.chromium.org/18132003/diff/2001/chrome/browser/sync/glue/s...
chrome/browser/sync/glue/sync_backend_host.cc:737:
types_to_download.PutAll(clean_first_types);
In what cases does the registrar decide to remove some of the clean_first_types
from the union you passed in?

[Nicolas Zea, 2013-07-01 23:27:45]

Done, PTAL

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
File chrome/browser/sync/glue/bookmark_model_associator.cc (right):

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
chrome/browser/sync/glue/bookmark_model_associator.cc:715: (native_version !=
sync_version || native_version != 0)) {
On 2013/07/01 21:10:18, timsteele wrote:
> So.. this is 
> 
> !(native_version == sync_version && native_version == 0)
> 
> I think you want to remove this (here and below) :)

Done.

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
chrome/browser/sync/glue/sync_backend_host.cc:737:
types_to_download.PutAll(clean_first_types);
On 2013/07/01 21:10:18, timsteele wrote:
> In what cases does the registrar decide to remove some of the
clean_first_types
> from the union you passed in?

I'm not sure I understand the question? The registrar should never remove clean
first types from the union. The issue is that clean first types are in the
unique situation of being "enabled", needing a partial purge, and needing to be
downloaded, all at once.

[tim (not reviewing), 2013-07-02 18:54:18]

LGTM

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

https://chromiumcodereview.appspot.com/18132003/diff/2001/chrome/browser/sync...
chrome/browser/sync/glue/sync_backend_host.cc:737:
types_to_download.PutAll(clean_first_types);
On 2013/07/01 23:27:45, Nicolas Zea wrote:
> On 2013/07/01 21:10:18, timsteele wrote:
> > In what cases does the registrar decide to remove some of the
> clean_first_types
> > from the union you passed in?
> 
> I'm not sure I understand the question? The registrar should never remove
clean
> first types from the union. The issue is that clean first types are in the
> unique situation of being "enabled", needing a partial purge, and needing to
be
> downloaded, all at once.

I guess it wasn't clear what was happening with clean_first_types; we pass it in
to ConfigureDataTypes, which returns "types to download", so intuitively I would
assume "clean_first_types are already in types_to_download".   But that's not
the case.

[commit-bot: I haz the power, 2013-07-03 00:18:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/18132003/25001

[commit-bot: I haz the power, 2013-07-03 00:52:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-03 16:54:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/18132003/45001

[commit-bot: I haz the power, 2013-07-03 18:46:17]

Change committed as 210013