Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 18119011: Streamline picture_record_recurring_ bench. (Closed)

Created:
7 years, 5 months ago by Tom Hudson
Modified:
7 years, 5 months ago
Reviewers:
reed1, mtklein, tomhudson
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Streamline picture_record_recurring_ bench. Reduce benchmark runtime from ~17 ms to ~13.25ms by moving SkPaint construction out of the inner loop and by using random colors in the SkPaints instead of sequential integers, which were seeing bad hashing. This doesn't actually improve our performance, but makes the benchmark more focused on pure recording costs. BUG= Committed: http://code.google.com/p/skia/source/detail?r=10003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M bench/PictureRecordBench.cpp View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tomhudson
When we're running the picture_record_recurring_paint_dictionary benchmark, we spend a lot of time in the SkPaint ...
7 years, 5 months ago (2013-07-11 10:19:50 UTC) #1
reed1
lgtm very good change -- focus in one what we care about
7 years, 5 months ago (2013-07-11 13:49:20 UTC) #2
mtklein
lgtm
7 years, 5 months ago (2013-07-11 13:56:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/18119011/1
7 years, 5 months ago (2013-07-11 14:00:37 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 14:26:11 UTC) #5
Message was sent while issue was closed.
Change committed as 10003

Powered by Google App Engine
This is Rietveld 408576698