Issue 18118004: Keep Skia compiling on Clang by changing false to NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18118004: Keep Skia compiling on Clang by changing false to NULL (Closed)

Created:
7 years, 5 months ago by rtrieu

Modified:
7 years, 5 months ago

Reviewers:
robertphillips, reed1

CC:
rmistry

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Clang has stricter checking for conversion to a null pointer. In C++11 mode, false will produce an error if it is used in a place that expects a pointer. Change these cases to NULL. Committed: http://code.google.com/p/skia/source/detail?r=9800

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/animator/SkAnimatorScript.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/animator/SkScriptRuntime.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rtrieu@google.com/18118004/1

7 years, 5 months ago (2013-06-28 11:40:18 UTC) #3

Message was sent while issue was closed.

Change committed as 9800

Expand Messages | Collapse Messages