Issue 18114010: Bug fix: Merging language sets to create 'translate_blocked_languages' may be evaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18114010: Bug fix: Merging language sets to create 'translate_blocked_languages' may be evaded (Closed)

Created:
7 years, 5 months ago by hajimehoshi

Modified:
7 years, 5 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Bug fix: Merging language sets to create 'translate_blocked_languages' may be evaded Because of the 'return' sentence in the previous migrating, the merging process may have been evaded. BUG=253794 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209331

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
	M	chrome/browser/translate/translate_prefs.cc	View		1 chunk	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/18114010/1

7 years, 5 months ago (2013-06-28 05:31:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=170927

7 years, 5 months ago (2013-06-29 00:09:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/18114010/1

7 years, 5 months ago (2013-06-29 06:46:30 UTC) #5

Message was sent while issue was closed.

Change committed as 209331

Expand Messages | Collapse Messages