Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 18113004: Implement Promise.prototype.then and Promise.prototype.catch (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement Promise.prototype.then and Promise.prototype.catch We are implementing DOM/Promises. This CL implements Promise.prototype.then and Promise.prototype.catch. All methods are marked as Custom and there are many boilerplate. we will fix them in a future CL. R=abarth, haraken BUG=243345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153560

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Binding an object to a function by attaching the object to the FunctionTemplate of the function #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -27 lines) Patch
A LayoutTests/fast/js/Promise-already-fulfilled.html View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-already-fulfilled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Promise-catch.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-catch-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-chain.html View 1 chunk +68 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-chain-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-exception.html View 1 chunk +36 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-exception-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Promise-fulfill.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-fulfill-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/Promise-init.html View 2 chunks +19 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/Promise-init-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-reject.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-reject-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve.html View 1 chunk +32 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-with-then-exception.html View 1 chunk +34 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-with-then-exception-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-with-then-fulfill.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-with-then-fulfill-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-with-then-reject.html View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-with-then-reject-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-simple.html View 1 chunk +36 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-simple-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/js/Promise-simple-fulfill.html View 1 chunk +27 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-simple-fulfill-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Promise-simple-fulfill-inside-callback.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-simple-fulfill-inside-callback-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Promise-then.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-then-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-then-without-callbacks.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-then-without-callbacks-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 2 3 4 5 chunks +93 lines, -3 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yhirano
7 years, 5 months ago (2013-06-28 08:41:38 UTC) #1
abarth-chromium
This one is too hard for me to review tonight. I'll look again in the ...
7 years, 5 months ago (2013-07-01 05:49:38 UTC) #2
yhirano
https://codereview.chromium.org/18113004/diff/8001/Source/bindings/v8/custom/V8PromiseCustom.cpp File Source/bindings/v8/custom/V8PromiseCustom.cpp (right): https://codereview.chromium.org/18113004/diff/8001/Source/bindings/v8/custom/V8PromiseCustom.cpp#newcode171 Source/bindings/v8/custom/V8PromiseCustom.cpp:171: v8::Local<v8::Value> value = V8ScriptRunner::compileAndRunInternalScript(script, isolate); On 2013/07/01 05:49:38, abarth ...
7 years, 5 months ago (2013-07-01 06:58:53 UTC) #3
yhirano
Hi, can you review this CL?
7 years, 5 months ago (2013-07-03 16:47:22 UTC) #4
abarth-chromium
On 2013/07/03 16:47:22, yhirano wrote: > Hi, can you review this CL? Sorry, it dropped ...
7 years, 5 months ago (2013-07-03 18:27:06 UTC) #5
abarth-chromium
lgtm https://codereview.chromium.org/18113004/diff/13001/Source/bindings/v8/custom/V8PromiseCustom.cpp File Source/bindings/v8/custom/V8PromiseCustom.cpp (right): https://codereview.chromium.org/18113004/diff/13001/Source/bindings/v8/custom/V8PromiseCustom.cpp#newcode127 Source/bindings/v8/custom/V8PromiseCustom.cpp:127: v8::Local<v8::Value> result = v8::Undefined(args.GetIsolate()); Seems like you can ...
7 years, 5 months ago (2013-07-03 18:30:23 UTC) #6
yhirano
https://codereview.chromium.org/18113004/diff/13001/Source/bindings/v8/custom/V8PromiseCustom.cpp File Source/bindings/v8/custom/V8PromiseCustom.cpp (right): https://codereview.chromium.org/18113004/diff/13001/Source/bindings/v8/custom/V8PromiseCustom.cpp#newcode127 Source/bindings/v8/custom/V8PromiseCustom.cpp:127: v8::Local<v8::Value> result = v8::Undefined(args.GetIsolate()); On 2013/07/03 18:30:23, abarth wrote: ...
7 years, 5 months ago (2013-07-04 01:12:16 UTC) #7
yhirano
haraken@, do you have any comments?
7 years, 5 months ago (2013-07-04 06:08:02 UTC) #8
haraken
Though I didn't read the tests, the binding implementation LGTM1
7 years, 5 months ago (2013-07-04 06:12:55 UTC) #9
yhirano
Thank you very much.
7 years, 5 months ago (2013-07-04 06:15:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18113004/21001
7 years, 5 months ago (2013-07-04 06:16:14 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 07:02:41 UTC) #12
Message was sent while issue was closed.
Change committed as 153560

Powered by Google App Engine
This is Rietveld 408576698