Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2037)

Unified Diff: chrome/browser/net/proxy_service_factory.h

Issue 18112018: Cleanup the UseSharedProxies preference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/proxy_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/proxy_service_factory.h
diff --git a/chrome/browser/net/proxy_service_factory.h b/chrome/browser/net/proxy_service_factory.h
index c0c26fdf09e7b38b90555c4cdc28eb27d43636f7..154f5e90aa9b35c1d74b2cc903bf87cee86606f7 100644
--- a/chrome/browser/net/proxy_service_factory.h
+++ b/chrome/browser/net/proxy_service_factory.h
@@ -18,6 +18,12 @@ class ProxyConfigServiceImpl;
}
#endif // defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS)
+typedef chromeos::ProxyConfigServiceImpl PrefProxyConfigTracker;
+#else
+typedef PrefProxyConfigTrackerImpl PrefProxyConfigTracker;
+#endif // defined(OS_CHROMEOS)
+
namespace net {
class NetLog;
class NetworkDelegate;
@@ -34,13 +40,19 @@ class ProxyServiceFactory {
// about the proxy configuration by calling its UpdateProxyConfig method.
static ChromeProxyConfigService* CreateProxyConfigService();
-#if defined(OS_CHROMEOS)
- static chromeos::ProxyConfigServiceImpl* CreatePrefProxyConfigTracker(
- PrefService* pref_service);
-#else
- static PrefProxyConfigTrackerImpl* CreatePrefProxyConfigTracker(
- PrefService* pref_service);
-#endif // defined(OS_CHROMEOS)
+ // Creates a PrefProxyConfigTracker that tracks preferences of a
+ // profile. On ChromeOS it additionaly tracks local state for shared proxy
+ // settings. This tracker should be used if the profile's preferences should
+ // be respected. On ChromeOS's signin screen this is for example not the case.
+ static PrefProxyConfigTracker* CreatePrefProxyConfigTrackerOfProfile(
+ PrefService* profile_prefs,
+ PrefService* local_state_prefs);
+
+ // Creates a PrefProxyConfigTracker that tracks local state only. This tracker
+ // should be used for the system request context and the signin screen
+ // (ChromeOS only).
+ static PrefProxyConfigTracker* CreatePrefProxyConfigTrackerOfLocalState(
+ PrefService* local_state_prefs);
// Create a proxy service according to the options on command line.
static net::ProxyService* CreateProxyService(
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/proxy_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698