Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 18106003: Respect policy when migrating existing icons with no AppId. (Closed)

Created:
7 years, 5 months ago by pastarmovj
Modified:
7 years, 5 months ago
Reviewers:
gab
CC:
chromium-reviews
Visibility:
Public.

Description

Respect policy when migrating existing icons with no AppId. BUG=173237, 28104 TEST=Pinned Chrome icons should not spawn second icon when chrome is started with userDataDir policy set. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209327

Patch Set 1 #

Patch Set 2 : Remove extra whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/shell_integration_win.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pastarmovj
Hi Gabriel, can you please review this tiny fix for the AppId migration code. It ...
7 years, 5 months ago (2013-06-28 15:18:19 UTC) #1
gab
Very nice, lgtm!
7 years, 5 months ago (2013-06-28 17:47:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/18106003/3001
7 years, 5 months ago (2013-06-28 17:55:28 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 20:25:26 UTC) #4
Message was sent while issue was closed.
Change committed as 209327

Powered by Google App Engine
This is Rietveld 408576698