Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 18094004: change WebViewImpl::inputModeOfFocusedElement to return lowered string. (Closed)

Created:
7 years, 5 months ago by yoichio
Modified:
7 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

change WebViewImpl::inputModeOfFocusedElement to return lowered string. This string casted to WebString is compared to string such as "kana", "verbatim". The input mode attribute is enumerated attribute [1], which should be case-insensitive [2]. We had better normalize values in Blink because it's a web standard matter. [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#attr-fe-inputmode [2] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#enumerated-attribute In this cl we decide to use lower case. and delete an unused test case. BUG=244688 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153609

Patch Set 1 #

Patch Set 2 : add comment to WebTextInputInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/WebKit/chromium/tests/data/input_mode_default_url.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/data/input_mode_default_verbatim.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/data/input_mode_textarea_verbatim.html View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebTextInputInfo.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoichio
Please review.
7 years, 5 months ago (2013-07-04 07:21:25 UTC) #1
tkent
Please write a reason of lower casing in the CL description. A comment in WebTextInputInfo.h ...
7 years, 5 months ago (2013-07-04 09:52:02 UTC) #2
yoichio
7 years, 5 months ago (2013-07-05 02:27:53 UTC) #3
yoichio
On 2013/07/05 02:27:53, yoichio wrote: Add description
7 years, 5 months ago (2013-07-05 02:28:28 UTC) #4
tkent
lgtm > We need compare them ignoring case but WebString has no such a way ...
7 years, 5 months ago (2013-07-05 03:15:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/18094004/3001
7 years, 5 months ago (2013-07-05 03:26:45 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-05 04:53:51 UTC) #7
Message was sent while issue was closed.
Change committed as 153609

Powered by Google App Engine
This is Rietveld 408576698