Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 18093002: linux: make libc urandom override work for non-glibc too (2nd try) (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

linux: make libc urandom override work for non-glibc too This patch attempts to generalise the linux libc urandom override, so that it works for non-glibc linux platforms too. BUG=255215 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209281

Patch Set 1 #

Patch Set 2 : attempt to fix the ASAN build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -16 lines) Patch
M sandbox/linux/services/libc_urandom_override.cc View 1 5 chunks +89 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@jln: 17066002 landed but was reverted in 18069003 because it broke the linux ASAN build. ...
7 years, 5 months ago (2013-06-27 16:52:54 UTC) #1
jln (very slow on Chromium)
On 2013/06/27 16:52:54, Mostyn Bramley-Moore wrote: > @jln: 17066002 landed but was reverted in 18069003 ...
7 years, 5 months ago (2013-06-27 22:06:47 UTC) #2
Mostyn Bramley-Moore
Bug created: http://code.google.com/p/chromium/issues/detail?id=255215
7 years, 5 months ago (2013-06-27 22:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18093002/2001
7 years, 5 months ago (2013-06-27 22:16:24 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 10:54:08 UTC) #5
Message was sent while issue was closed.
Change committed as 209281

Powered by Google App Engine
This is Rietveld 408576698