linux: make libc urandom override work for non-glibc too (2nd try)

linux: make libc urandom override work for non-glibc too

This patch attempts to generalise the linux libc urandom override, so that it works for non-glibc linux platforms too.

BUG=255215
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209281

[Mostyn Bramley-Moore, 2013-06-27 16:52:54]

@jln: 17066002 landed but was reverted in 18069003 because it broke the linux
ASAN build.  In patchset 1 I reapplied the old commit, patchset 2 has a fix (to
make it easy to spot the difference).

Are the extra ifdefs worth keeping, in order to call InitLibcFileIOFunctions
from InitLibcUrandomOverrides (this was something you requested in 17066002)?

[jln (very slow on Chromium), 2013-06-27 22:06:47]

On 2013/06/27 16:52:54, Mostyn Bramley-Moore wrote:
> @jln: 17066002 landed but was reverted in 18069003 because it broke the linux
> ASAN build.  In patchset 1 I reapplied the old commit, patchset 2 has a fix
(to
> make it easy to spot the difference).
> 
> Are the extra ifdefs worth keeping, in order to call InitLibcFileIOFunctions
> from InitLibcUrandomOverrides (this was something you requested in 17066002)?

Yeah, let's keep it! lgtm.

Do you want to create a bug to track this ? (And link it to this review with
BUG=). It's always a good thing to have a bug linked for hairy patches, it
allows to track the reverts etc easily.

[Mostyn Bramley-Moore, 2013-06-27 22:13:58]

Bug created: http://code.google.com/p/chromium/issues/detail?id=255215

[commit-bot: I haz the power, 2013-06-27 22:16:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/18093002/2001

[commit-bot: I haz the power, 2013-06-29 10:54:08]

Change committed as 209281