Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 18089009: Hovered/active/focused nodes will never share style with siblings/cousins. (Closed)

Created:
7 years, 5 months ago by rune
Modified:
7 years, 5 months ago
Reviewers:
eseidel, eae, dglazkov1
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Hovered/active/focused nodes will never share style with siblings/cousins. For any given hovered/active node at a given time, other hovered/active nodes are either ancestors or descendants of that node. Since style sharing is looking at siblings and cousins, hovered/active nodes will never share style. Similarly, there's always a single focused element in a document, hence it will never share style with another node. This change bails out early for style sharing in those cases. BUG=255189 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153529

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased on top of recent master #

Patch Set 3 : Fixed indentation and review issue in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A PerformanceTests/CSS/HoverUpdate.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rune
Not sure if the added performance test is the most suitable, but it shows the ...
7 years, 5 months ago (2013-06-27 21:44:18 UTC) #1
rune
https://codereview.chromium.org/18089009/diff/1/PerformanceTests/CSS/HoverUpdate.html File PerformanceTests/CSS/HoverUpdate.html (right): https://codereview.chromium.org/18089009/diff/1/PerformanceTests/CSS/HoverUpdate.html#newcode27 PerformanceTests/CSS/HoverUpdate.html:27: var d2 = document.getElementById("d2"); Unused d1/d2 left-overs from earlier ...
7 years, 5 months ago (2013-07-02 07:49:55 UTC) #2
rune
> Unused d1/d2 left-overs from earlier iteration of the test. Removed in Patch Set 3.
7 years, 5 months ago (2013-07-02 08:28:12 UTC) #3
rune
Added potential reviewers.
7 years, 5 months ago (2013-07-03 08:31:07 UTC) #4
eae
LGTM, thanks!
7 years, 5 months ago (2013-07-03 18:13:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/18089009/7002
7 years, 5 months ago (2013-07-03 18:25:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=14924
7 years, 5 months ago (2013-07-03 19:27:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/18089009/7002
7 years, 5 months ago (2013-07-03 19:43:57 UTC) #8
commit-bot: I haz the power
Change committed as 153529
7 years, 5 months ago (2013-07-03 22:02:03 UTC) #9
rune
7 years, 5 months ago (2013-07-05 12:29:47 UTC) #10
Message was sent while issue was closed.
On 2013/07/03 22:02:03, I haz the power (commit-bot) wrote:
> Change committed as 153529

Was reverted because performance test relied on a dom object only available with
the WebKit performance framework (WebKit/Tools/Scripts/run-perf-tests).

New attempt, testing :focus this time:

https://codereview.chromium.org/18764003

Powered by Google App Engine
This is Rietveld 408576698