Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 180833004: Gather histogram for received packets indicating losses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to comments, and add small optimization Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/quic/quic_connection_logger.cc ('K') | « net/quic/quic_connection_logger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f411637178c9dfc7034c2ba930c04f3f6ce247da..c5da07f1d2eaaf0ae46037966615ad1492f29e9b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10228,6 +10228,22 @@ other types of suffix sets.
</summary>
</histogram>
+<histogram name="Net.QuicSession.PacketReceived_Ack" units="SequenceNumber">
+ <summary>
+ Each bucket contains the number of packets with a corresponding sequence
+ number that were received by the client, and hence the client ACKed the
+ packet.
+ </summary>
+</histogram>
+
+<histogram name="Net.QuicSession.PacketReceived_Nack" units="SequenceNumber">
+ <summary>
+ Each bucket contains the number of packets with a corresponding sequence
+ number were not received by the client, but for which there were later
+ packet sequence numbers received, and hence the client NACKed the packet.
+ </summary>
+</histogram>
+
<histogram name="Net.QuicSession.PublicResetAddressMismatch"
enum="QuicAddressMismatch">
<summary>
@@ -34513,6 +34529,23 @@ other types of suffix sets.
<affected-histogram name="Media.VideoCaptureManager"/>
</fieldtrial>
+<fieldtrial name="Net.QuicSession.PacketReceived" separator="_">
+ <group name="CONNECTION_UNKNOWN" label="Connections via WiFi are tallied."/>
+ <group name="CONNECTION_ETHERNET"
+ label="Connections via ethernet are tallied, but this may include
+ connections to a wifi bridge."/>
+ <group name="CONNECTION_WIFI"
+ label="Connections via WiFi are tallied, but this may include
+ connections to a mobile hotspot."/>
+ <group name="CONNECTION_2G" label="Connections mobile 2G are tallied."/>
+ <group name="CONNECTION_3G" label="Connections mobile 3G are tallied."/>
+ <group name="CONNECTION_4G" label="Connections mobile 4G are tallied."/>
+ <group name="CONNECTION_NONE"
+ label="Connections via NO(?) network are tallied (should be empty)."/>
+ <affected-histogram name="Net.QuicSession.PacketReceived_Ack"/>
+ <affected-histogram name="Net.QuicSession.PacketReceived_Nack"/>
+</fieldtrial>
+
<fieldtrial name="NetConnectivity" separator=".">
<group name="53.100B" label="100 bytes of data on port 53."/>
<group name="53.100B.NoProxy"
« net/quic/quic_connection_logger.cc ('K') | « net/quic/quic_connection_logger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698