Implement platform_util::OpenExternal on ChromeOS

Implement platform_util::OpenExternal on ChromeOS

And remove OS-conditional code from ChromeShellWindowDelegate.

BUG=249265, 256338
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209751

[Ken Rockot(use gerrit already), 2013-07-01 20:16:18]

+benwells for apps change; can we add an OWNERS file for chrome/browser/ui/apps?
Looks like chrome/browser/ui/extensions owners would be an appropriate start.

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
File chrome/browser/platform_util_chromeos.cc (right):

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
chrome/browser/platform_util_chromeos.cc:32: params.window_action =
chrome::NavigateParams::SHOW_WINDOW;
Is there any reason why an explicit SHOW_WINDOW would be a problem here?

[benwells, 2013-07-02 00:00:28]

On 2013/07/01 20:16:18, rockot wrote:
> +benwells for apps change; can we add an OWNERS file for
chrome/browser/ui/apps?
> Looks like chrome/browser/ui/extensions owners would be an appropriate start.
> 
>
https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
> File chrome/browser/platform_util_chromeos.cc (right):
> 
>
https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
> chrome/browser/platform_util_chromeos.cc:32: params.window_action =
> chrome::NavigateParams::SHOW_WINDOW;
> Is there any reason why an explicit SHOW_WINDOW would be a problem here?

c/b/ui/app lgtm
I'll get an owners added there.

[sky, 2013-07-02 00:35:42]

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
File chrome/browser/platform_util_chromeos.cc (right):

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
chrome/browser/platform_util_chromeos.cc:32: params.window_action =
chrome::NavigateParams::SHOW_WINDOW;
On 2013/07/01 20:16:18, rockot wrote:
> Is there any reason why an explicit SHOW_WINDOW would be a problem here?

Not that I can think of. In fact I suspect the old code was problematic if
FindOrCreateTabbedBrowser created a new browser.

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
chrome/browser/platform_util_chromeos.cc:65: } else if (url.is_valid()) {
What code is this being expected on? It seems like there is no need for a
posttask, but maybe I'm missing something.

[sky, 2013-07-02 00:35:55]

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
File chrome/browser/platform_util_chromeos.cc (right):

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
chrome/browser/platform_util_chromeos.cc:65: } else if (url.is_valid()) {
On 2013/07/02 00:35:42, sky wrote:
> What code is this being expected on? It seems like there is no need for a
> posttask, but maybe I'm missing something.

That should be thread. Sorry.

[Ken Rockot(use gerrit already), 2013-07-02 01:37:51]

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
File chrome/browser/platform_util_chromeos.cc (right):

https://codereview.chromium.org/18083022/diff/1/chrome/browser/platform_util_...
chrome/browser/platform_util_chromeos.cc:65: } else if (url.is_valid()) {
On 2013/07/02 00:35:55, sky wrote:
> On 2013/07/02 00:35:42, sky wrote:
> > What code is this being expected on? It seems like there is no need for a
> > posttask, but maybe I'm missing something.
> 
> That should be thread. Sorry.

ExternalProtocolHandler does call OpenExternal from the IO thread, but we could
always add a check here to call OpenURL directly when possible.

[sky, 2013-07-02 14:25:07]

LGTM

[commit-bot: I haz the power, 2013-07-02 15:47:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/18083022/1

[commit-bot: I haz the power, 2013-07-02 19:31:43]

Change committed as 209751