Omnibox: Improve Bookmarks Provider Comments

Omnibox: Improve Bookmarks Provider Comments

These improvement come from un-followed-up suggestions from
https://codereview.chromium.org/10913262/

(The suggestions were offered after the code was submitted.)

BUG=
NOTRY=1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209280

[Mark P, 2013-06-28 22:16:25]

simple and easy.

In the paragraph, I only inserted a fragment in the middle.  The whole thing got
re-wrapped so it looks like a bigger change than it is.

--mark

[Peter Kasting, 2013-06-28 22:18:22]

LGTM

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
chrome/browser/autocomplete/bookmark_provider.cc:211: // Once all term factors
have been calculated they are summed. The
How come you rewrapped this to have such shorter line lengths?

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
chrome/browser/autocomplete/bookmark_provider.cc:214: // the bookmarks models
only matches terms to the beginning of words
Nit: bookmarks models -> bookmark model

[Mark P, 2013-06-28 22:38:57]

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
chrome/browser/autocomplete/bookmark_provider.cc:211: // Once all term factors
have been calculated they are summed. The
On 2013/06/28 22:18:22, Peter Kasting wrote:
> How come you rewrapped this to have such shorter line lengths?

Re-wrapped by hand.

https://codereview.chromium.org/18083017/diff/1/chrome/browser/autocomplete/b...
chrome/browser/autocomplete/bookmark_provider.cc:214: // the bookmarks models
only matches terms to the beginning of words
On 2013/06/28 22:18:22, Peter Kasting wrote:
> Nit: bookmarks models -> bookmark model

Done.

[commit-bot: I haz the power, 2013-06-28 22:39:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/18083017/5001

[Peter Kasting, 2013-06-28 22:44:14]

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
chrome/browser/autocomplete/bookmark_provider.cc:217: // sum of factors is at
most 1.) This sum is then multiplied against the
Super nit: "sum" will fit on the previous line, which will result in
chain-rewrapping the subsequent lines.

[Mark P, 2013-06-28 22:55:05]

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
chrome/browser/autocomplete/bookmark_provider.cc:217: // sum of factors is at
most 1.) This sum is then multiplied against the
On 2013/06/28 22:44:14, Peter Kasting wrote:
> Super nit: "sum" will fit on the previous line, which will result in
> chain-rewrapping the subsequent lines.

It looks ugly like that because the line above is comparably short.

[Peter Kasting, 2013-06-28 22:57:17]

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/18083017/diff/5001/chrome/browser/autocomplet...
chrome/browser/autocomplete/bookmark_provider.cc:217: // sum of factors is at
most 1.) This sum is then multiplied against the
On 2013/06/28 22:55:05, Mark P wrote:
> On 2013/06/28 22:44:14, Peter Kasting wrote:
> > Super nit: "sum" will fit on the previous line, which will result in
> > chain-rewrapping the subsequent lines.
> 
> It looks ugly like that because the line above is comparably short.

We are wrapping our lines based on aesthetics of making them similar lengths??

[commit-bot: I haz the power, 2013-06-29 10:53:48]

Change committed as 209280