content/browser/indexed_db/leveldb/leveldb_comparator.h - Issue 18075008: IndexedDB: Switch key/value handling from vector<char> to std::string

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/indexed_db/leveldb/leveldb_comparator.h

Issue 18075008: IndexedDB: Switch key/value handling from vector<char> to std::string (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc ('K') | « content/browser/indexed_db/indexed_db_transaction.cc ('k') | content/browser/indexed_db/leveldb/leveldb_database.h » ('j') | content/child/indexed_db/indexed_db_dispatcher.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_	5 #ifndef CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_

6 #define CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_	6 #define CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_

7	7

8 #include "base/strings/string16.h"	8 #include "base/strings/string_piece.h"

9	9

10 namespace content {	10 namespace content {

11	11

12 class LevelDBSlice;

13

14 class LevelDBComparator {	12 class LevelDBComparator {
	alecflett 2013/07/09 18:26:30 Seems like we could get rid of this adapter class Seems like we could get rid of this adapter class entirely with a little more work (for another patch...) jsbell 2013/07/09 19:41:46 Agreed. Show quoted text On 2013/07/09 18:26:30, alecflett wrote: > Seems like we could get rid of this adapter class entirely with a little more > work (for another patch...) Agreed.
15 public:	13 public:

16 virtual ~LevelDBComparator() {}	14 virtual ~LevelDBComparator() {}

17	15

18 virtual int Compare(const LevelDBSlice& a, const LevelDBSlice& b) const = 0;	16 virtual int Compare(const base::StringPiece& a,

	17 const base::StringPiece& b) const = 0;

19 virtual const char* Name() const = 0;	18 virtual const char* Name() const = 0;

20 };	19 };

21	20

22 } // namespace content	21 } // namespace content

23	22

24 #endif // CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_	23 #endif // CONTENT_BROWSER_INDEXED_DB_LEVELDB_LEVELDB_COMPARATOR_H_

OLD	NEW