Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 18066013: add a chromium_builder_asan target (Closed)

Created:
7 years, 5 months ago by Dirk Pranke
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

add a chromium_builder_asan target When I changed the ASAN builders to use 'all_webkit' in r202619 I made them build a bunch of stuff they don't care about. This change adds an asan builder target so that we can control which binaries are built in the source tree. A follow-on change will switch the bots to use this. R=inferno@chromium.org, jochen@chromium.org BUG=258605 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210882

Patch Set 1 #

Patch Set 2 : make chromium_builder_asan a non-ios target #

Patch Set 3 : add content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M build/all.gyp View 1 2 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dirk Pranke
7 years, 5 months ago (2013-07-09 20:47:56 UTC) #1
aarya
lgtm. can you please add content_browsertests, looks like you are missing that in the list ...
7 years, 5 months ago (2013-07-09 20:51:16 UTC) #2
inferno
lgtm ing from my chromium account.
7 years, 5 months ago (2013-07-09 20:52:15 UTC) #3
Dirk Pranke
On 2013/07/09 20:51:16, aarya wrote: > lgtm. can you please add content_browsertests, looks like you ...
7 years, 5 months ago (2013-07-09 20:55:01 UTC) #4
aarya
lgtm
7 years, 5 months ago (2013-07-09 20:56:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/18066013/7002
7 years, 5 months ago (2013-07-10 00:27:13 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 01:53:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/18066013/7002
7 years, 5 months ago (2013-07-10 17:32:37 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 17:51:46 UTC) #9
Message was sent while issue was closed.
Change committed as 210882

Powered by Google App Engine
This is Rietveld 408576698