Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Issue 18062006: Revert r15361 "Improved function entry hook coverage" because of ARM build error. (Closed)

Created:
7 years, 5 months ago by ulan
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert r15361 "Improved function entry hook coverage" because of ARM build error. R=siggi@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -472 lines) Patch
M include/v8.h View 1 chunk +3 lines, -10 lines 0 comments Download
M src/api.cc View 4 chunks +5 lines, -33 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 6 chunks +11 lines, -26 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/code-stubs.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +16 lines, -3 lines 0 comments Download
M src/frames.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/frames.cc View 3 chunks +16 lines, -5 lines 0 comments Download
M src/frames-inl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +5 lines, -19 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 5 chunks +1 line, -12 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +41 lines, -25 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +81 lines, -293 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sigurður Ásgeirsson
lgtm
7 years, 5 months ago (2013-06-27 15:25:31 UTC) #1
ulan
7 years, 5 months ago (2013-06-27 15:31:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r15365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698