Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 18053009: Fix git tests to work regardless of global gitconfig. (Closed)

Created:
7 years, 5 months ago by iannucci
Modified:
7 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Fix git tests to work regardless of global gitconfig. Previously if one or both of these values were unset, the tests would simply fail because `git config` returns 1. R=dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=208966

Patch Set 1 #

Total comments: 1

Patch Set 2 : example.com #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tests/test-lib.sh View 1 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
7 years, 5 months ago (2013-06-27 19:03:32 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/18053009/diff/1/tests/test-lib.sh File tests/test-lib.sh (right): https://codereview.chromium.org/18053009/diff/1/tests/test-lib.sh#newcode54 tests/test-lib.sh:54: git config user.email 'TestDood@cooltown.co' Nit: this should probably ...
7 years, 5 months ago (2013-06-27 19:15:57 UTC) #2
iannucci
On 2013/06/27 19:15:57, Dirk Pranke wrote: > lgtm > > https://codereview.chromium.org/18053009/diff/1/tests/test-lib.sh > File tests/test-lib.sh (right): ...
7 years, 5 months ago (2013-06-27 19:18:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/18053009/5001
7 years, 5 months ago (2013-06-27 19:19:12 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 19:21:12 UTC) #5
Message was sent while issue was closed.
Change committed as 208966

Powered by Google App Engine
This is Rietveld 408576698