Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 18052011: Fix CopyFromBackingStore when there's no cg_layer_. (Closed)

Created:
7 years, 5 months ago by msimonides
Modified:
7 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix CopyFromBackingStore when there's no cg_layer_. In CopyFromBackingStore use the cg_bitmap_ as the source in case cg_layer_ hasn't been created yet. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209399

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M content/browser/renderer_host/backing_store_mac.mm View 1 chunk +12 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
msimonides
7 years, 5 months ago (2013-06-28 07:17:50 UTC) #1
Nico
lgtm This isn't right for hidpi screens, but neither is the current code.
7 years, 5 months ago (2013-06-28 19:30:02 UTC) #2
msimonides
On 2013/06/28 19:30:02, Nico wrote: > lgtm > > This isn't right for hidpi screens, ...
7 years, 5 months ago (2013-07-01 06:40:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/18052011/1
7 years, 5 months ago (2013-07-01 06:41:30 UTC) #4
commit-bot: I haz the power
Change committed as 209399
7 years, 5 months ago (2013-07-01 08:28:22 UTC) #5
Nico
7 years, 5 months ago (2013-07-01 16:54:59 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/18052011/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/backing_store_mac.mm (right):

https://codereview.chromium.org/18052011/diff/1/content/browser/renderer_host...
content/browser/renderer_host/backing_store_mac.mm:165: bool
BackingStoreMac::CopyFromBackingStore(const gfx::Rect& rect,
for hidpi: one probably would hand in a scale factor output is desired in too
(or hand it out if this always uses the backing store's scale factor), then
allocate the output at pixel size rect * scale, and apply a scale to
temp_context if necessary.

https://codereview.chromium.org/18052011/diff/1/content/browser/renderer_host...
content/browser/renderer_host/backing_store_mac.mm:173:
CGContextTranslateCTM(temp_context, 0.0, size().height());
size() returns logical size, which isn't right for mirroring in y. This should
probably use rect.height() instead, possibly scaled by the output scale factor
if necessary (if the output scale factor is different from the backing store's).

Powered by Google App Engine
This is Rietveld 408576698