Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1511)

Unified Diff: dart/tests/lib/mirrors/reflect_model_test.dart

Issue 18052004: Implement JsMethodMirror.parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/lib/mirrors/reflect_model_test.dart
diff --git a/dart/tests/lib/mirrors/reflect_model_test.dart b/dart/tests/lib/mirrors/reflect_model_test.dart
index 567651c477dd1b31806d56a90a0eea603cc9c99e..e5eabdf8869b6616b4675037063d94b1e1b46999 100644
--- a/dart/tests/lib/mirrors/reflect_model_test.dart
+++ b/dart/tests/lib/mirrors/reflect_model_test.dart
@@ -9,67 +9,10 @@ import 'dart:mirrors';
import 'package:expect/expect.dart';
import 'model.dart';
+import 'stringify.dart';
isNoSuchMethodError(e) => e is NoSuchMethodError;
-name(DeclarationMirror mirror) {
- return (mirror == null) ? '<null>' : stringify(mirror.simpleName);
-}
-
-stringifyMap(Map map) {
- var buffer = new StringBuffer('{');
- bool first = true;
- for (String key in map.keys.map(MirrorSystem.getName).toList()..sort()) {
- if (!first) buffer.write(', ');
- first = false;
- buffer.write(key);
- buffer.write(': ');
- buffer.write(stringify(map[new Symbol(key)]));
- }
- return (buffer..write('}')).toString();
-}
-
-stringifySymbol(Symbol symbol) => 's(${MirrorSystem.getName(symbol)})';
-
-writeDeclarationOn(DeclarationMirror mirror, StringBuffer buffer) {
- buffer.write(stringify(mirror.simpleName));
- if (mirror.owner != null) {
- buffer.write(' in ');
- buffer.write(name(mirror.owner));
- }
- if (mirror.isPrivate) buffer.write(', private');
- if (mirror.isTopLevel) buffer.write(', top-level');
-}
-
-stringifyVariable(VariableMirror variable) {
- var buffer = new StringBuffer('Variable(');
- writeDeclarationOn(variable, buffer);
- if (variable.isStatic) buffer.write(', static');
- if (variable.isFinal) buffer.write(', final');
- return (buffer..write(')')).toString();
-}
-
-stringifyMethod(MethodMirror method) {
- var buffer = new StringBuffer('Method(');
- writeDeclarationOn(method, buffer);
- if (method.isStatic) buffer.write(', static');
- if (method.isGetter) buffer.write(', getter');
- if (method.isSetter) buffer.write(', setter');
- if (method.isConstructor) buffer.write(', constructor');
- return (buffer..write(')')).toString();
-}
-
-stringify(value) {
- if (value is Map) return stringifyMap(value);
- if (value is VariableMirror) return stringifyVariable(value);
- if (value is MethodMirror) return stringifyMethod(value);
- if (value is Symbol) return stringifySymbol(value);
- if (value == null) return '<null>';
- throw 'Unexpected value: $value';
-}
-
-expect(expected, actual) => Expect.stringEquals(expected, stringify(actual));
-
main() {
var unnamed = new Symbol('');
var field = new Symbol('field');

Powered by Google App Engine
This is Rietveld 408576698