dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart - Issue 18052004: Implement JsMethodMirror.parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 18052004: Implement JsMethodMirror.parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('j') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

index 3adbd635aca1e16a64f64099bddb8779c2070077..0ae4696c703bac3a2df63802ae9081e3c5458e0a 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

@@ -663,6 +663,11 @@ class TypeRepresentationGenerator extends DartTypeVisitor {

builder.write('null');

}

+ visitVoidType(VoidType type, _) {

+ // TODO(ahe): Reify void type ("null" means "dynamic").

+ builder.write('null');

+ }

visitType(DartType type, _) {

compiler.internalError('Unexpected type: $type (${type.kind})');

}