Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18051003: Use a direct include of time headers in base/, part 1. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, sadrul, jar (doing other things), tfarina, gavinp+memory_chromium.org, asvitkine+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, jshin+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of time headers in base/, part 1. BUG=254986 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M base/build_time.h View 1 chunk +1 line, -1 line 0 comments Download
M base/build_time.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M base/deferred_sequenced_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_default.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_glib.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_libevent.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_libevent.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram_base.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_counters.h View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/mime_util_xdg.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18051003/1
7 years, 5 months ago (2013-06-27 18:19:05 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=170233
7 years, 5 months ago (2013-06-27 21:40:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18051003/1
7 years, 5 months ago (2013-06-27 22:15:50 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 00:49:10 UTC) #4
Message was sent while issue was closed. 
Change committed as 209044

Powered by Google App Engine
This is Rietveld 408576698