Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 18045007: Show more different NaCl loading errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc
===================================================================
--- ppapi/native_client/src/trusted/plugin/service_runtime.cc (revision 212679)
+++ ppapi/native_client/src/trusted/plugin/service_runtime.cc (working copy)
@@ -728,17 +728,21 @@
"ServiceRuntime: failed to create sel_ldr launcher");
return false;
}
+ nacl::string error_message;
bool started = tmp_subprocess->Start(plugin_->pp_instance(),
params.url.c_str(),
params.uses_irt,
params.uses_ppapi,
params.enable_dev_interfaces,
params.enable_dyncode_syscalls,
- params.enable_exception_handling);
+ params.enable_exception_handling,
+ &error_message);
if (!started) {
NaClLog(LOG_ERROR, "ServiceRuntime::Start (start failed)\n");
- params.error_info->SetReport(ERROR_SEL_LDR_LAUNCH,
- "ServiceRuntime: failed to start");
+ params.error_info->SetReportWithConsoleOnlyError(
+ ERROR_SEL_LDR_LAUNCH,
+ "ServiceRuntime: failed to start",
+ error_message);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698