Show more different NaCl loading errors.

ppapi/native_client/src/trusted/plugin/plugin_error.h

 /*
  * Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * Error codes and data structures used to report errors when loading a nexe.
  */
 
@@ skipping 97 matching lines @@
     Reset();
   }
 
   void Reset() {
     SetReport(ERROR_UNKNOWN, std::string());
   }
 
   void SetReport(PluginErrorCode error_code, const std::string& message) {
     error_code_ = error_code;
     message_ = message;
+    console_message_ = message;
+  }
+
+  // console_message is a part of error that is logged to javascript console

[Mark Seaborn, 2013/07/18 22:15:49]

"javascript" -> "Javascript" or "JavaScript"

[halyavin, 2013/07/19 09:06:20]

Done.

+  // but is not reported to javascript on the page.  This is need to report

[Mark Seaborn, 2013/07/18 22:15:49]

More specifically: "not reported to JavaScript via .lastError".

"need" -> "needed".  Actually, "used" would be better.

[halyavin, 2013/07/19 09:06:20]

Done.

+  // internal errors which may easily change in new versions of the browser.
+  void SetReportWithConsoleOnlyError(PluginErrorCode error_code,
+                                     const std::string& message,
+                                     const std::string& console_message) {
+    error_code_ = error_code;
+    message_ = message;
+    console_message_ = message + console_message;

[Mark Seaborn, 2013/07/18 22:15:49]

Shouldn't there be some punctuation between the messages, like a colon?  What's
an example of the output here?  Isn't this going to output something like
"ServiceRuntime: failed to startNaClSocketPair() failed"?

[halyavin, 2013/07/19 09:06:20]

I used semicolon so that we don't have 2 colons in a row.

[Mark Seaborn, 2013/07/19 15:25:30]

FWIW, I think multiple colons in a sentence are OK.

   }
 
   PluginErrorCode error_code() const {
     return error_code_;
   }
 
   void PrependMessage(const std::string& prefix) {
     message_ = prefix + message_;
+    console_message_ = prefix + console_message_;
   }
 
   const std::string& message() const {
     return message_;
   }
 
+  const std::string& console_message() const {
+    return console_message_;
+  }
+
  private:
   PluginErrorCode error_code_;
   std::string message_;
+  std::string console_message_;
   NACL_DISALLOW_COPY_AND_ASSIGN(ErrorInfo);
 };
 
 }  // namespace plugin
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H