Set CrOS touchpad Tap Paused property to false during initialization

Set CrOS touchpad Tap Paused property to false during initialization

On CrOS We turn on/off the touchpad Tap-to-click (TTC) feature based
on the cursor (mouse pointer) visibility change events. Thus, the two
things gets out-of-sync if someone changes the cursor without sending
such an event. The CL fix such a leak where we directly set the mouse
cursor when initializing the root window controller in Shell.

Contributed by sheckylin@chromium.org

BUG=252364, 244656
TEST=Tested on device.

Change-Id: I71152517cdbc8b65ebb0613c073f51550e7759f0

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209628

[Shecky Lin, 2013-06-27 10:19:12]

Scott: Could you help review this quick change? This is to make sure the CrOS
touchpad TTC feature continue to work after a browser crash. Thanks!

[sky, 2013-06-27 16:09:18]

+mazda

This doesn't seem right to me. It seems like RootWindowHostX11 should take care
of this (if necessary).

[Shecky Lin, 2013-06-28 08:08:31]

Got it. I have fixed it.
mazda@: Can you take a look of this? Thanks!

[mazda, 2013-06-28 16:08:43]

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
File ui/aura/root_window_host_x11.cc (right):

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:891: // visible in
Shell::InitRootWindowController.
Should this be inside #if defined(OS_CHROMEOS)?

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:1074: LOG(ERROR) <<
"RootWindowHostX11::SetCrOSTapPaused";
Is this debug code?

[Shecky Lin, 2013-07-01 04:34:36]

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
File ui/aura/root_window_host_x11.cc (right):

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:891: // visible in
Shell::InitRootWindowController.
On 2013/06/28 16:08:43, mazda wrote:
> Should this be inside #if defined(OS_CHROMEOS)?

Done.

https://codereview.chromium.org/18043004/diff/4001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:1074: LOG(ERROR) <<
"RootWindowHostX11::SetCrOSTapPaused";
On 2013/06/28 16:08:43, mazda wrote:
> Is this debug code?

Oops, sorry. Done.

[mazda, 2013-07-01 07:59:08]

lgtm

[commit-bot: I haz the power, 2013-07-01 08:05:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheckylin@chromium.org/18043004/9001

[Shecky Lin, 2013-07-01 08:16:09]

sky@: Could you take a final look of this and LGTM it if it looks fine? Thanks.

[sky, 2013-07-01 14:04:26]

LGTM

https://codereview.chromium.org/18043004/diff/9001/ui/aura/root_window_host_x...
File ui/aura/root_window_host_x11.cc (right):

https://codereview.chromium.org/18043004/diff/9001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:1076: void
RootWindowHostX11::SetCrOSTapPaused(bool state) {
Can you put the ifdef in this method (similar to OnCursorVisibilityChanged).
That way there is only an ifdef around the implementation, not at each call
site.

[Shecky Lin, 2013-07-02 03:50:30]

https://codereview.chromium.org/18043004/diff/9001/ui/aura/root_window_host_x...
File ui/aura/root_window_host_x11.cc (right):

https://codereview.chromium.org/18043004/diff/9001/ui/aura/root_window_host_x...
ui/aura/root_window_host_x11.cc:1076: void
RootWindowHostX11::SetCrOSTapPaused(bool state) {
On 2013/07/01 14:04:26, sky wrote:
> Can you put the ifdef in this method (similar to OnCursorVisibilityChanged).
> That way there is only an ifdef around the implementation, not at each call
> site.

Done.

[commit-bot: I haz the power, 2013-07-02 03:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheckylin@chromium.org/18043004/20001

[commit-bot: I haz the power, 2013-07-02 06:51:28]

Change committed as 209628