Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 18041002: compositionstart event's data should contain text to replace. (Closed)

Created:
7 years, 5 months ago by kochi
Modified:
7 years, 5 months ago
Reviewers:
tkent, rniwa-cr
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, yosin_UTC9
Visibility:
Public.

Description

compositionstart event's data should contain text to replace. spec: http://www.w3.org/TR/DOM-Level-3-Events/#event-type-compositionstart As far as I tested, IE10 on Windows7 and Firefox22 on Linux conforms the spec's behavior about event.data of compositionstart event. BUG=247878 TEST=layoutest Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153319

Patch Set 1 : . #

Patch Set 2 : Add a testcase for selection. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M LayoutTests/fast/events/ime-composition-events-001.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/ime-composition-events-001-expected.txt View 1 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +7 lines, -1 line 2 comments Download

Messages

Total messages: 12 (0 generated)
kochi
tkent-san, Could you review this?
7 years, 5 months ago (2013-06-27 10:10:33 UTC) #1
kochi
On 2013/06/27 10:10:33, Takayoshi Kochi wrote: > tkent-san, > > Could you review this? I'll ...
7 years, 5 months ago (2013-06-27 20:53:07 UTC) #2
kochi
On 2013/06/27 20:53:07, Takayoshi Kochi wrote: > On 2013/06/27 10:10:33, Takayoshi Kochi wrote: > > ...
7 years, 5 months ago (2013-06-28 06:55:07 UTC) #3
tkent
Do other browser conform to the specification?
7 years, 5 months ago (2013-06-30 23:32:32 UTC) #4
kochi
On 2013/06/30 23:32:32, tkent wrote: > Do other browser conform to the specification? IE10 and ...
7 years, 5 months ago (2013-07-01 03:48:36 UTC) #5
tkent
lgtm > IE10 and the latest firefox conform the spec, as far as I know. ...
7 years, 5 months ago (2013-07-01 03:51:07 UTC) #6
kochi
On 2013/07/01 03:51:07, tkent wrote: > lgtm > > > IE10 and the latest firefox ...
7 years, 5 months ago (2013-07-01 03:59:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/18041002/10001
7 years, 5 months ago (2013-07-01 03:59:42 UTC) #8
commit-bot: I haz the power
Change committed as 153319
7 years, 5 months ago (2013-07-01 05:34:52 UTC) #9
rniwa-cr
https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editing/Editor.cpp File Source/core/editing/Editor.cpp (right): https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editing/Editor.cpp#newcode1256 Source/core/editing/Editor.cpp:1256: target->dispatchEvent(CompositionEvent::create(eventNames().compositionstartEvent, m_frame->document()->domWindow(), selectionText)); You could have simply called selectedText() ...
7 years, 5 months ago (2013-07-15 21:46:52 UTC) #10
kochi
https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editing/Editor.cpp File Source/core/editing/Editor.cpp (right): https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editing/Editor.cpp#newcode1256 Source/core/editing/Editor.cpp:1256: target->dispatchEvent(CompositionEvent::create(eventNames().compositionstartEvent, m_frame->document()->domWindow(), selectionText)); On 2013/07/15 21:46:52, rniwa-cr wrote: > ...
7 years, 5 months ago (2013-07-16 09:50:41 UTC) #11
kochi
7 years, 5 months ago (2013-07-16 09:50:56 UTC) #12
Message was sent while issue was closed.
On 2013/07/16 09:50:41, Takayoshi Kochi wrote:
>
https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editin...
> File Source/core/editing/Editor.cpp (right):
> 
>
https://chromiumcodereview.appspot.com/18041002/diff/10001/Source/core/editin...
> Source/core/editing/Editor.cpp:1256:
>
target->dispatchEvent(CompositionEvent::create(eventNames().compositionstartEvent,
> m_frame->document()->domWindow(), selectionText));
> On 2013/07/15 21:46:52, rniwa-cr wrote:
> > You could have simply called selectedText() here as I've done so in
> > https://bugs.webkit.org/show_bug.cgi?id=118684.
> 
> Done.

The CL is https://codereview.chromium.org/19357002/

Powered by Google App Engine
This is Rietveld 408576698