Add viewport settings for ImageDocument and MediaDocument

Add viewport settings for MediaDocument

MediaDocument is used when navigating directly to an audio or video resource.
Use viewport width=device-width so that one doesn't need to zoom in order to
use the video controls.

Add viewport settings for ImageDocument

On (mobile) platforms which have a viewport (e.g. Android) it is currently
necessary to zoom in to see the image at 100% resolution even if it fits on the
page. The width=device-width setting fixes this, and does not affect (desktop)
platforms that lack a viewport.

BUG=254978
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153704

[philipj_slow, 2013-06-27 14:19:02]

Fixes for http://code.google.com/p/chromium/issues/detail?id=254978

I think I failed to preserve the two separate commits, please let me know if
there's a way to do that using git cl upload...

[philipj_slow, 2013-06-27 14:20:09]

See the bug for before/after screenshots from ContentShell on Android.

[acolwell GONE FROM CHROMIUM, 2013-06-27 15:29:27]

When you say "100% resolution" do you mean that if the image is 100 pixels wide
it displays as 100 pixels or are you saying that the image should take up the
entire width of the display independent of its actual width?

I was always under the impression that the image/media documents were intended
to display the content at it actual size and not scale it in any way. In the
case of the media document, would expanding the controls to take up the whole
width be a viable option?

[philipj_slow, 2013-06-28 06:50:30]

On 2013/06/27 15:29:27, acolwell wrote:
> When you say "100% resolution" do you mean that if the image is 100 pixels
wide
> it displays as 100 pixels or are you saying that the image should take up the
> entire width of the display independent of its actual width?

I just mean that a 100px image is 100 CSS pixels big, not that all images are
stretched to fill the viewport.

> I was always under the impression that the image/media documents were intended
> to display the content at it actual size and not scale it in any way. In the
> case of the media document, would expanding the controls to take up the whole
> width be a viable option?

Yeah, one could do that, but only in addition to the viewport fix, not instead
of it. If one only add CSS video { width: 100% }, then what one will see is tiny
controls, that when zoomed in to a usable size will require horizontal panning.

[acolwell GONE FROM CHROMIUM, 2013-06-28 16:09:18]

lgtm

[commit-bot: I haz the power, 2013-07-01 15:07:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/18034007/1

[commit-bot: I haz the power, 2013-07-01 15:28:39]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[acolwell GONE FROM CHROMIUM, 2013-07-01 15:30:52]

@abarth OWNERS review please.

[abarth-chromium, 2013-07-01 17:44:19]

Test please.

[philipj_slow, 2013-07-03 12:30:44]

On 2013/07/01 17:44:19, abarth wrote:
> Test please.

Would a layout test be appropriate for this, or just a unit test that verifies
that the DOM is what I think it should be? I was unable to find any tests for
ImageDocument, while
LayoutTests/fast/events/media-focus-in-standalone-media-document.html looks
related for MediaDocument.

[abarth-chromium, 2013-07-03 18:21:03]

On 2013/07/03 12:30:44, philipj wrote:
> Would a layout test be appropriate for this, or just a unit test that verifies
> that the DOM is what I think it should be?

Yeah, I would just write a layout test that checks the DOM to make sure this
element is there.

> I was unable to find any tests for ImageDocument, while
> LayoutTests/fast/events/media-focus-in-standalone-media-document.html looks
> related for MediaDocument.

It's easy to write a LayoutTest for ImageDocument.  You just create an iframe
with a src that points at an image.  Then you can use the contentWindow property
of the iframe to peek inside and see what the DOM looks like.

[philipj_slow, 2013-07-04 12:13:56]

@abarth, thanks for the tips!

I've written and run the LayoutTests, please check if they are acceptable.

[abarth-chromium, 2013-07-08 18:58:44]

lgtm

[abarth-chromium, 2013-07-08 18:58:49]

Thanks for the test.

[commit-bot: I haz the power, 2013-07-08 18:59:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/18034007/15001

[commit-bot: I haz the power, 2013-07-08 20:39:00]

Change committed as 153704