Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 18031010: Add allAvailableSensorsActive field to the WebDeviceMotionData. (Closed)

Created:
7 years, 5 months ago by timvolodine
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add allAvailableSensorsActive field to the WebDeviceMotionData. This field is needed to determine whether the data stored in WebDeviceMotionData is complete, i.e. no more data can be provided because the data from all available sensors has been received. BUG=135804 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153190

Patch Set 1 #

Total comments: 2

Patch Set 2 : allAvailableSensorsActive -> allAvailableSensorsAreActive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M public/platform/WebDeviceMotionData.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
timvolodine
very tiny addition to the DeviceMotionData, this extra field is needed because according to spec ...
7 years, 5 months ago (2013-06-27 22:31:03 UTC) #1
abarth-chromium
LGTM w/ nit https://chromiumcodereview.appspot.com/18031010/diff/1/public/platform/WebDeviceMotionData.h File public/platform/WebDeviceMotionData.h (right): https://chromiumcodereview.appspot.com/18031010/diff/1/public/platform/WebDeviceMotionData.h#newcode71 public/platform/WebDeviceMotionData.h:71: bool allAvailableSensorsActive : 1; allAvailableSensorsActive -> ...
7 years, 5 months ago (2013-06-27 22:38:00 UTC) #2
timvolodine
https://chromiumcodereview.appspot.com/18031010/diff/1/public/platform/WebDeviceMotionData.h File public/platform/WebDeviceMotionData.h (right): https://chromiumcodereview.appspot.com/18031010/diff/1/public/platform/WebDeviceMotionData.h#newcode71 public/platform/WebDeviceMotionData.h:71: bool allAvailableSensorsActive : 1; On 2013/06/27 22:38:00, abarth wrote: ...
7 years, 5 months ago (2013-06-27 22:44:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/18031010/4001
7 years, 5 months ago (2013-06-27 22:45:00 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 04:02:21 UTC) #5
Message was sent while issue was closed.
Change committed as 153190

Powered by Google App Engine
This is Rietveld 408576698