Issue 18024003: ARM Skia NEON patches - 08 - Cleaning / possible fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18024003: ARM Skia NEON patches - 08 - Cleaning / possible fix (Closed)

Created:
7 years, 5 months ago by kevin.petit.not.used.account

Modified:
7 years, 5 months ago

Reviewers:
reed1, djsollen, caryclark, tomhudson

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ARM Skia NEON patches - 08 - Cleaning / possible fix Misc: use SK_PMCOLOR_BYTE_ORDER where appropriate Before SK_PMCOLOR_BYTE_ORDER was introduced, I had written my own macro for the same purpose. I had at the time spotted these two places where it seemed to be useful. The change in SkCreateCGImageRef.cpp may be a bugfix or a bug for the second occurrence, I'm not sure... BUG= Committed: http://code.google.com/p/skia/source/detail?r=10071

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -35 lines)			Patch
	M	src/core/SkDevice.cpp	View		1 chunk	+8 lines, -25 lines	0 comments	Download
	M	src/utils/mac/SkCreateCGImageRef.cpp	View		3 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm, but I would like to get another set of eyes on this one before ...

7 years, 5 months ago (2013-07-15 12:29:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/18024003/1

7 years, 5 months ago (2013-07-15 12:51:02 UTC) #3

Message was sent while issue was closed.

Change committed as 10071

Expand Messages | Collapse Messages