Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 18023018: @viewport lengths relative to initial font. (Closed)

Created:
7 years, 5 months ago by rune
Modified:
7 years, 5 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, apavlov+blink_chromium.org, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

@viewport lengths relative to initial font. em/rem/ex Were incorrectly computed relative to the documentElement font. BUG=257070 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153784

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A LayoutTests/css3/device-adapt/viewport-relative-font.html View 1 chunk +27 lines, -0 lines 1 comment Download
A LayoutTests/css3/device-adapt/viewport-relative-font-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
7 years, 5 months ago (2013-07-03 16:27:20 UTC) #1
kenneth.r.christiansen
lgtm
7 years, 5 months ago (2013-07-03 17:12:38 UTC) #2
Peter Beverloo
lgtm, but you'll need a core/ owner in order to submit, which may be a ...
7 years, 5 months ago (2013-07-04 13:17:44 UTC) #3
Peter Beverloo
https://codereview.chromium.org/18023018/diff/1/LayoutTests/css3/device-adapt/viewport-relative-font.html File LayoutTests/css3/device-adapt/viewport-relative-font.html (right): https://codereview.chromium.org/18023018/diff/1/LayoutTests/css3/device-adapt/viewport-relative-font.html#newcode23 LayoutTests/css3/device-adapt/viewport-relative-font.html:23: alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352)); It doesn't matter ...
7 years, 5 months ago (2013-07-04 13:20:28 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-09 11:41:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/18023018/1
7 years, 5 months ago (2013-07-09 12:59:27 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 14:10:40 UTC) #7
Message was sent while issue was closed.
Change committed as 153784

Powered by Google App Engine
This is Rietveld 408576698