Convert CreateCdmBuffer() to use size_t for |capacity|

Convert CreateCdmBuffer() to use size_t for |capacity|

TEST=media mojo unittests pass

Committed: https://crrev.com/45b8930a00cacbefdebc98834a961b78833429fd
Cr-Commit-Position: refs/heads/master@{#381309}

[jrummell, 2016-03-14 23:35:51]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-03-14 23:35:52]

PTAL

[xhwang, 2016-03-15 06:17:22]

lgtm % nit for discussion

https://chromiumcodereview.appspot.com/1802183002/diff/1/media/cdm/simple_cdm...
File media/cdm/simple_cdm_buffer.cc (right):

https://chromiumcodereview.appspot.com/1802183002/diff/1/media/cdm/simple_cdm...
media/cdm/simple_cdm_buffer.cc:21: return nullptr;
This should really never happen since the caller only uses uint32. A DCHECK here
plus the checked_cast below seem sufficient.

https://chromiumcodereview.appspot.com/1802183002/diff/1/media/mojo/services/...
File media/mojo/services/mojo_cdm_allocator.cc (right):

https://chromiumcodereview.appspot.com/1802183002/diff/1/media/mojo/services/...
media/mojo/services/mojo_cdm_allocator.cc:55: return nullptr;
ditto

[jrummell, 2016-03-15 18:49:42]

Thanks for the review.

https://codereview.chromium.org/1802183002/diff/1/media/cdm/simple_cdm_buffer.cc
File media/cdm/simple_cdm_buffer.cc (right):

https://codereview.chromium.org/1802183002/diff/1/media/cdm/simple_cdm_buffer...
media/cdm/simple_cdm_buffer.cc:21: return nullptr;
On 2016/03/15 06:17:22, xhwang wrote:
> This should really never happen since the caller only uses uint32. A DCHECK
here
> plus the checked_cast below seem sufficient.

Done.

https://codereview.chromium.org/1802183002/diff/1/media/mojo/services/mojo_cd...
File media/mojo/services/mojo_cdm_allocator.cc (right):

https://codereview.chromium.org/1802183002/diff/1/media/mojo/services/mojo_cd...
media/mojo/services/mojo_cdm_allocator.cc:55: return nullptr;
On 2016/03/15 06:17:22, xhwang wrote:
> ditto

Done.

[jrummell, 2016-03-15 18:54:36]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-03-15 18:54:37]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1802183002/#ps20001
(title: "DCHECKs")

[commit-bot: I haz the power, 2016-03-15 18:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802183002/20001

[xhwang, 2016-03-15 18:57:37]

https://codereview.chromium.org/1802183002/diff/20001/media/cdm/simple_cdm_bu...
File media/cdm/simple_cdm_buffer.cc (right):

https://codereview.chromium.org/1802183002/diff/20001/media/cdm/simple_cdm_bu...
media/cdm/simple_cdm_buffer.cc:20:
static_cast<size_t>(std::numeric_limits<uint32_t>::max()));
OOC, can you drop the static_cast since both size_t and uint32_t are unsigned?

[xhwang, 2016-03-15 18:58:07]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-03-15 18:58:29]

I unchecked the CQ for the question I have. Sorry :)

[jrummell, 2016-03-15 19:43:12]

Updated. Thanks.

https://codereview.chromium.org/1802183002/diff/20001/media/cdm/simple_cdm_bu...
File media/cdm/simple_cdm_buffer.cc (right):

https://codereview.chromium.org/1802183002/diff/20001/media/cdm/simple_cdm_bu...
media/cdm/simple_cdm_buffer.cc:20:
static_cast<size_t>(std::numeric_limits<uint32_t>::max()));
On 2016/03/15 18:57:37, xhwang wrote:
> OOC, can you drop the static_cast since both size_t and uint32_t are unsigned?

Done.

[jrummell, 2016-03-15 19:43:16]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-03-15 19:43:16]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1802183002/#ps40001
(title: "remove cast")

[commit-bot: I haz the power, 2016-03-15 19:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802183002/40001

[commit-bot: I haz the power, 2016-03-15 21:00:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-15 21:02:50]

Description was changed from

==========
Convert CreateCdmBuffer() to use size_t for |capacity|

TEST=media mojo unittests pass
==========

to

==========
Convert CreateCdmBuffer() to use size_t for |capacity|

TEST=media mojo unittests pass

Committed: https://crrev.com/45b8930a00cacbefdebc98834a961b78833429fd
Cr-Commit-Position: refs/heads/master@{#381309}
==========

[commit-bot: I haz the power, 2016-03-15 21:02:51]

Patchset 3 (id:??) landed as
https://crrev.com/45b8930a00cacbefdebc98834a961b78833429fd
Cr-Commit-Position: refs/heads/master@{#381309}