Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 18001004: Remove Hangul IME with migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update Tests: Remove Ko/Kr entry and mozc-hangul Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index ce2ada0d573442000225218d9c53dab772ec7663..23b5eca4ebe91c9019faf42c876894911571cd05 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -735,6 +735,7 @@ void Preferences::NotifyPrefChanged(const std::string* pref_name) {
// Do not check |*pref_name| of the prefs for remembering current/previous
// input methods here. We're only interested in initial values of the prefs.
+ // TODO(nona): remove all IME preference entries. crbug.com/256102
for (size_t i = 0; i < language_prefs::kNumChewingBooleanPrefs; ++i) {
if (!pref_name ||
*pref_name == language_prefs::kChewingBooleanPrefs[i].pref_name) {
@@ -772,9 +773,13 @@ void Preferences::NotifyPrefChanged(const std::string* pref_name) {
}
if (!pref_name ||
*pref_name == prefs::kLanguageHangulKeyboard) {
- SetLanguageConfigString(language_prefs::kHangulSectionName,
- language_prefs::kHangulKeyboardConfigName,
- hangul_keyboard_.GetValue());
+ std::vector<std::string> new_input_method_ids;
+ if (input_method_manager_->MigrateKoreanKeyboard(
+ hangul_keyboard_.GetValue(),
+ &new_input_method_ids)) {
+ preload_engines_.SetValue(JoinString(new_input_method_ids, ','));
+ hangul_keyboard_.SetValue("dummy_value_already_migrated");
+ }
}
if (!pref_name || *pref_name == prefs::kLanguageHangulHanjaBindingKeys) {
SetLanguageConfigString(language_prefs::kHangulSectionName,
« no previous file with comments | « chrome/browser/chromeos/input_method/mock_input_method_manager.cc ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698