Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4221)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 18001004: Remove Hangul IME with migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update Tests: Remove Ko/Kr entry and mozc-hangul Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
index d9a40a7527ff75b58b32932f8ee2b366ce0e9de8..29c35f935c8ffbb283cc7af262cb0f92d7d94f6e 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
@@ -338,7 +338,7 @@ TEST_F(InputMethodManagerImplTest, TestEnableLayoutsNonUsHardwareKeyboard) {
}
TEST_F(InputMethodManagerImplTest, TestActiveInputMethods) {
- manager_->EnableLayouts("ko", ""); // Korean
+ manager_->EnableLayouts("ja", ""); // Japanese
EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());
scoped_ptr<InputMethodDescriptors> methods(
manager_->GetActiveInputMethods());
@@ -349,7 +349,7 @@ TEST_F(InputMethodManagerImplTest, TestActiveInputMethods) {
"xkb:us::eng");
EXPECT_TRUE(Contain(*methods.get(), *id_to_find));
id_to_find = manager_->GetInputMethodUtil()->GetInputMethodDescriptorFromId(
- "xkb:kr:kr104:kor");
+ "xkb:jp::jpn");
EXPECT_TRUE(Contain(*methods.get(), *id_to_find));
}
@@ -848,12 +848,6 @@ TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithUsLayouts) {
EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());
EXPECT_EQ("us", xkeyboard_->last_layout_);
- // Do the same tests for Korean.
- EXPECT_FALSE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("us", xkeyboard_->last_layout_);
-
manager_->RemoveObserver(&observer);
}
@@ -885,27 +879,6 @@ TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithJpLayout) {
EXPECT_EQ("jp", xkeyboard_->last_layout_);
}
-TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithKoLayout) {
- // Do the same tests for Korean.
- InitComponentExtension();
- InitIBusBus();
- manager_->EnableLayouts("ko", "xkb:us::eng");
- EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());
- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("us", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
- manager_->SwitchToPreviousInputMethod();
- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("us", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
-}
-
TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithJpIme) {
InitComponentExtension();
InitIBusBus();
@@ -956,40 +929,6 @@ TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithJpIme) {
EXPECT_EQ("jp", xkeyboard_->last_layout_);
}
-TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithKoIme) {
- InitComponentExtension();
- InitIBusBus();
- manager_->SetState(InputMethodManager::STATE_BROWSER_SCREEN);
- std::vector<std::string> ids;
- ids.push_back("xkb:kr:kr104:kor");
- ids.push_back("mozc-hangul");
- EXPECT_TRUE(manager_->EnableInputMethods(ids));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("mozc-hangul", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
-
- // Add Dvorak.
- ids.push_back("xkb:us:dvorak:eng");
- EXPECT_TRUE(manager_->EnableInputMethods(ids));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("mozc-hangul", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
- EXPECT_TRUE(manager_->SwitchInputMethod(
- ui::Accelerator(ui::VKEY_HANGUL, ui::EF_NONE)));
- EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());
- EXPECT_EQ("kr(kr104)", xkeyboard_->last_layout_);
-}
-
TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {
TestObserver observer;
manager_->AddObserver(&observer);
@@ -1287,7 +1226,7 @@ TEST_F(InputMethodManagerImplTest,
input_method_ids.push_back("mozc");
input_method_ids.push_back("mozc-jp");
input_method_ids.push_back("xkb:us::eng");
- input_method_ids.push_back("mozc-hangul");
+ input_method_ids.push_back(nacl_mozc_us_id);
manager_->MigrateOldInputMethods(&input_method_ids);
@@ -1303,14 +1242,14 @@ TEST_F(InputMethodManagerImplTest,
"xkb:us::eng"));
EXPECT_NE(input_method_ids.end(),
std::find(input_method_ids.begin(), input_method_ids.end(),
- "mozc-hangul"));
+ nacl_mozc_us_id));
}
TEST_F(InputMethodManagerImplTest,
AsyncComponentExtentionInitializeBeforeIBusDaemonConnection) {
const std::string xkb_id = "xkb:cz::cze";
- const std::string ime_id = "mozc-hangul";
+ const std::string ime_id = nacl_mozc_us_id;
const std::string fallback_id = "xkb:us::eng";
std::vector<std::string> ids;
ids.push_back(xkb_id);
@@ -1342,7 +1281,7 @@ TEST_F(InputMethodManagerImplTest,
TEST_F(InputMethodManagerImplTest,
AsyncComponentExtentionInitializeAfterIBusDaemonConnection) {
const std::string xkb_id = "xkb:cz::cze";
- const std::string ime_id = "mozc-hangul";
+ const std::string ime_id = nacl_mozc_us_id;
const std::string fallback_id = "xkb:us::eng";
std::vector<std::string> ids;
ids.push_back(xkb_id);

Powered by Google App Engine
This is Rietveld 408576698