Remove Hangul IME with migration.

Remove Hangul IME with migration.

New Hangul IME has 5 input method engine which has different keyboard layouts.
Old Hangul IME works them with specifying the configuration.
So migrated keyboard will be selected based on current configuration.

And new Hangul IME has alphanumeric input mode and it can be switched with HANGUL key.
So that Korean keyboard layout is no longer necessary.
We can ignore the case that the user enables ONLY Korean keyboard layout.
Korean keyboard layout is subset of US layout and only useful with Hangul IME.
Even there is the case active keyboard list will be fall backed to US layout.

BUG=None
TEST=Manually checked on link

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209627

[Seigo Nonaka, 2013-06-27 12:58:00]

Hi Shu and Carbo,

with this change, legacy Hangul IME will be removed and new Hangul IME will be
used by default.
Could you take a look?

Thank you.

[Shu Chen, 2013-06-28 03:06:53]

lgtm

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/preferences.cc:777: if (!pref_name || *pref_name ==
prefs::kLanguageHangulHanjaBindingKeys) {
this is no change?

[Seigo Nonaka, 2013-06-28 03:28:51]

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/preferences.cc:777: if (!pref_name || *pref_name ==
prefs::kLanguageHangulHanjaBindingKeys) {
Yes, above change is for migration.
All configuration for input method will be managed by extension side. 

I will remove all configuration items in Chrome in few days after migration.

On 2013/06/28 03:06:54, Shu Chen wrote:
> this is no change?

[Seigo Nonaka, 2013-06-28 03:29:32]

Adding Zach for committer review.
Zach, could you also take a look?

Thank you.

[Zachary Kuznia, 2013-06-28 19:36:47]

lgtm

[Seigo Nonaka, 2013-07-01 03:31:28]

Thank you for review!

Adding satorux@ as the owner of chrome/browser/chromeos.

Hi Satoru, could you take an owner review?
- chrome/browser/chromeos/preferences.cc

Thank you.
Seigo.

[satorux1, 2013-07-01 03:33:45]

chrome/browser/chromeos/preferences.cc LGTM with a nit

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/preferences.cc:777: if (!pref_name || *pref_name ==
prefs::kLanguageHangulHanjaBindingKeys) {
On 2013/06/28 03:28:51, Seigo Nonaka wrote:
> Yes, above change is for migration.
> All configuration for input method will be managed by extension side. 
> 
> I will remove all configuration items in Chrome in few days after migration.

Please file a bug and add the bug URL here.

> 
> On 2013/06/28 03:06:54, Shu Chen wrote:
> > this is no change?
>

[Seigo Nonaka, 2013-07-01 04:00:03]

PTAL?

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/18001004/diff/4001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/preferences.cc:777: if (!pref_name || *pref_name ==
prefs::kLanguageHangulHanjaBindingKeys) {
On 2013/07/01 03:33:45, satorux1 wrote:
> On 2013/06/28 03:28:51, Seigo Nonaka wrote:
> > Yes, above change is for migration.
> > All configuration for input method will be managed by extension side. 
> > 
> > I will remove all configuration items in Chrome in few days after migration.
> 
> Please file a bug and add the bug URL here.
> 
> > 
> > On 2013/06/28 03:06:54, Shu Chen wrote:
> > > this is no change?
> > 
> 

Done.

[satorux1, 2013-07-01 04:01:48]

LGTM

[Seigo Nonaka, 2013-07-01 04:19:09]

Thank you for your review!
Submitting...

[commit-bot: I haz the power, 2013-07-01 04:19:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/18001004/16001

[commit-bot: I haz the power, 2013-07-01 04:45:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-02 03:34:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/18001004/26001

[commit-bot: I haz the power, 2013-07-02 06:50:53]

Change committed as 209627