Issue 17999003: Deferred image decoding to support animated GIFs

Issue 17999003: Deferred image decoding to support animated GIFs (Closed)

Created:
7 years, 5 months ago by Alpha Left Google

Modified:
7 years, 5 months ago

Reviewers:
Stephen White

CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, dglazkov+blink, Rik, Stephen Chennney, jeez, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Deferred image decoding to support animated GIFs Adds support for decoding multi-frames images including GIF but not ICO. BUG=169377 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153813

Patch Set 1 #

Patch Set 2 : reuse decoder more #

Patch Set 3 : reuse more #

Patch Set 4 : removed filenameExtension #

Patch Set 5 : merged #

Patch Set 6 : layout test #

Total comments: 4

Patch Set 7 : done #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -106 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/DeferredImageDecoder.h	View	1 2 3	3 chunks	+8 lines, -3 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/DeferredImageDecoder.cpp	View	1 2 3	8 chunks	+77 lines, -44 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/DeferredImageDecoderTest.cpp	View		6 chunks	+90 lines, -2 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/ImageDecodingStoreTest.cpp	View	3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/ImageFrameGenerator.h	View	1 2 3 4	3 chunks	+13 lines, -9 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/ImageFrameGenerator.cpp	View	1 2 3 4	9 chunks	+32 lines, -27 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/ImageFrameGeneratorTest.cpp	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/LazyDecodingPixelRef.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp	View	3	4 chunks	+7 lines, -14 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/test/MockImageDecoder.h	View	1 2 3 4	3 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen White

LGTM https://codereview.chromium.org/17999003/diff/7009/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/17999003/diff/7009/LayoutTests/TestExpectations#newcode1849 LayoutTests/TestExpectations:1849: crbug.com/229120 virtual/deferred/fast/images/webp-color-profile-lossy.html [ ImageOnlyFailure ] Note: we now ...

7 years, 5 months ago (2013-07-09 15:01:20 UTC) #2

Alpha Left Google

https://codereview.chromium.org/17999003/diff/7009/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/17999003/diff/7009/LayoutTests/TestExpectations#newcode1849 LayoutTests/TestExpectations:1849: crbug.com/229120 virtual/deferred/fast/images/webp-color-profile-lossy.html [ ImageOnlyFailure ] On 2013/07/09 15:01:20, Stephen ...

7 years, 5 months ago (2013-07-09 19:20:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/17999003/17001

7 years, 5 months ago (2013-07-09 19:20:48 UTC) #4

Message was sent while issue was closed.

Change committed as 153813

Expand Messages | Collapse Messages