Make UTC times into local times for eroman@

Make UTC times into local times for eroman@

R=maruel@chromium.org
BUG=254519

[eroman, 2013-06-26 22:39:20]

Thanks Dan!

I'll leave the review to maruel, however this approach feels hacky.

Rather than scraping the DOM and fixing things up later, I suggest moving the
construction of the table entirely to javascript. In other words:

  (a) Have the main.html template output a JSON list with each row's data. In
this list, the timestamps are output as numbers, so they don't need to be parsed
later.

  (b) Construct the table and each row programatically from javascript, by
iterating through the data list.

[Dan Beam, 2013-06-26 22:47:23]

On 2013/06/26 22:39:20, eroman wrote:
> Thanks Dan!
> 
> I'll leave the review to maruel, however this approach feels hacky.

sure, agreed

> 
> Rather than scraping the DOM and fixing things up later, I suggest moving the
> construction of the table entirely to javascript. In other words:

that's fine assuming we support people that don't run JS. this way would just
show UTC to those that don't, though i really doubt anybody expects the web to
work for them today without JS...

> 
>   (a) Have the main.html template output a JSON list with each row's data. In
> this list, the timestamps are output as numbers, so they don't need to be
parsed
> later.
> 
>   (b) Construct the table and each row programatically from javascript, by
> iterating through the data list.

that'd be fine, it's just slightly more work :)

btw, there also does seem to be some timezone support in django after all -
https://docs.djangoproject.com/en/dev/topics/i18n/timezones/

[cmp, 2013-06-26 22:55:53]

+agable, can you do a review pass?

[Dan Beam, 2013-06-26 23:05:12]

On 2013/06/26 22:55:53, cmp wrote:
> +agable, can you do a review pass?

it may be worth deciding how this *should* be done before reviewing, btw...

[agable, 2013-07-01 22:34:41]

As I said in crbug.com/254519, I'd like to take a look at using {{
value|localtime }} in django to do this, but if we want this now I'm definitely
ok with doing it this way. LGTM.

[M-A Ruel, 2013-07-09 15:59:30]

On 2013/07/01 22:34:41, Aaron Gable wrote:
> As I said in crbug.com/254519, I'd like to take a look at using {{
> value|localtime }} in django to do this, but if we want this now I'm
definitely
> ok with doing it this way. LGTM.

"localtime" is poorly defined in django. The GAE server tries to guess the
user's timezone based on IP but that's likely wrong. The HTTP request never
contains the local time zone of the client.